Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

❓ SamplesColumnsProvider -- simplify the related component #565

Open
nicolay-r opened this issue Dec 6, 2024 · 0 comments
Open

❓ SamplesColumnsProvider -- simplify the related component #565

nicolay-r opened this issue Dec 6, 2024 · 0 comments
Assignees
@nicolay-r

Comments

@nicolay-r
Copy link
Owner

nicolay-r commented Dec 6, 2024 •
edited
Loading

#464 and #465 might be no longer relevant.

The only spot where we utilize the columns is here:

AREkit/arekit/contrib/utils/serializer.py

Line 24 in 0b18295

columns_provider=SampleColumnsProvider(store_labels=keep_labels),

That would results in obsolence of repository:

AREkit/arekit/common/data/input/repositories/sample.py

Line 10 in 0b18295

class BaseInputSamplesRepository(BaseInputRepository):

Do we need the related parameter?

AREkit/arekit/common/data/storages/base.py

Line 37 in 0b18295

def find_first_by_value(self, column_name, value):

@nicolay-r nicolay-r changed the title ❌SamplesColumnsProvider -- drop the related support ❌ SamplesColumnsProvider -- drop the related support Dec 6, 2024
@nicolay-r nicolay-r self-assigned this Dec 6, 2024
@nicolay-r nicolay-r changed the title ❌ SamplesColumnsProvider -- drop the related support :?: SamplesColumnsProvider -- simplify the related component Dec 6, 2024
@nicolay-r nicolay-r changed the title :?: SamplesColumnsProvider -- simplify the related component ❓ SamplesColumnsProvider -- simplify the related component Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolay-r nicolay-r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicolay-r