Makefile.PL is installing modules itself instead of just reporting prerequisites

[perlpunk]

I stumbled upon this: https://metacpan.org/release/NHORNE/Geo-Coder-Free-0.36/source/Makefile.PL#L42

system('perl -MCPAN -e \'CPAN::Shell->install("' . join('", "', @needfull) . '")\'');

A Makefile.PL should not mess with the user's system in that way.
Makefile.PL is there for reporting missing prerequisites and writing them to MYMETA.{json,yaml}, so that a CPAN client can install them if needed.
It should not install something on its own.

[nigelhorne]

The actual problem is that the database download and install should not be part of the Makefile.PL file. This has been a thorn for some time, I haven't got around to rewriting it.

Please feel free to submit a pull request, any fix must include a refactor of the database download and build system moving it out of the Makefile.