Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake export does not include version information #183

Open
Caldfir opened this issue Mar 31, 2018 · 1 comment
Open

cmake export does not include version information #183

Caldfir opened this issue Mar 31, 2018 · 1 comment

Comments

@Caldfir
Copy link

Caldfir commented Mar 31, 2018

The cmake exported info does not include the software version. This was a bit confusing since cmake itself ships with FindGLEW.cmake, which also doesn't identify the GLEW version. What currently happens during a build is that this library's export is consulted, no version is found, so the build falls-back to FindGLEW and ignores any version information specified in find_package. This makes the build look like it succeeded, but you can't actually be certain of the GLEW version it will actually attach to your project.

I believe the update would need to go somewhere in this block:

if(MAYBE_EXPORT)

The addition of CMakePackageConfigHelpers.cmake to the default cmake toolset should make this straightforward to update. A relevant example can be found here:
https://youtu.be/bsXLMQ6WgIk?t=2381

@nigels-com
Copy link
Owner

Thanks for the youtube link. I do agree that the cmake build could be further improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants