Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] "Version x.x.x available" notification should never be sent during the night #3728

Open
GrantAdkins opened this issue Jan 10, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@GrantAdkins
Copy link

As a user, I want the "Version x.x.x available" notification to only be sent during daylight hours so that I am not woken up by non-urgent notifications thanks to AAPS being granted the ability to bypass the Do not disturb feature.

Amateur Technical Comment:

I had a quick look at the code, and it seems my key_last_successful_version_check_timestamp value must be set to 1:46am, resulting in me being woken up at that time every night by the notification. If the VersionCheckerUtilsImpl class' triggerCheckVersion method were to be modified to change any non-daylight time values of key_last_successful_version_check_timestamp, that would avoid the checkVersion method being called when the user is typically asleep.

@MilosKozak MilosKozak added the enhancement New feature or request label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants