Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CD] Make Python and Node versions in a single file #88

Open
Privat33r-dev opened this issue Apr 30, 2024 · 0 comments
Open

[CD] Make Python and Node versions in a single file #88

Privat33r-dev opened this issue Apr 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Privat33r-dev
Copy link
Collaborator

Currently it's a slight mess:

  • poetry.lock:24: python-versions = ">=3.6"
  • pyproject.toml:40: python = ">=3.8,<4.0"
  • dockerfile:2: FROM python:3.10-alpine as python-base
  • tests.yml: [python-versions = ">=3.6](python-version: '3.10')
  • cd.yml: skipped, so kind of random, I guess (If the .python-version file doesn't exist Python or PyPy version from the PATH will be used.)
  • Pypi returns warning on CI because version is skipped.

That's kind of a big mess and pain to update. I might've even missed some Python versions.

I'd recommend to use Python 3.9 version everywhere except for Docker Containers. The reasoning is provided below:

  • We want to support wider array of devices, hence we need to support older versions.
  • Python versions are backward-compatible, but not forward-compatible, so it makes sense to focus on the oldest version to support.
  • According to Status of Python Versions, 3.8 end of life is in 6 months, so it makes sense to skip it straight to 3.9.
  • Performance of Python depends on the version, so it makes sense to ship container with higher version than used for testing (matrix testing can be applied to avoid deprecation issues)

Node versions are another story (less complicated to our luck), but I skip this discussion for now.

@Privat33r-dev Privat33r-dev changed the title Make Python and Node versions in a single file [CD] Make Python and Node versions in a single file May 1, 2024
@Privat33r-dev Privat33r-dev added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant