Use FQCN for builtin actions

Fixes all ansible-lint errors.

Author: nossralf

handlers/main.yml

@@ -1,7 +1,7 @@
 # handlers file
 ---
 - name: restart haproxy
-  service:
+  ansible.builtin.service:
     name: haproxy
     state: "{{ haproxy_restart_handler_state }}"
   when: service_default_state | default('started') == 'started'

molecule/default/converge.yml

@@ -4,6 +4,6 @@
   become: true
   pre_tasks:
     - name: include vars
-      include_vars: "{{ playbook_dir }}/../../tests/vars/main.yml"
+      ansible.builtin.include_vars: "{{ playbook_dir }}/../../tests/vars/main.yml"
   roles:
     - ../../../

tasks/acl.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: acl | create directories
-  file:
+  ansible.builtin.file:
     path: "{{ item.dest | dirname }}"
     state: directory
     owner: "{{ item.owner | default('root') }}"
@@ -12,7 +12,7 @@
     - haproxy-acl-create-directories
 
 - name: acl | update files
-  template:
+  ansible.builtin.template:
     src: etc/haproxy/acl.j2
     dest: "{{ item.dest }}"
     owner: "{{ item.owner | default('root') }}"

tasks/certificates.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: certificates | create directories
-  file:
+  ansible.builtin.file:
     path: "{{ item.dest | dirname }}"
     state: directory
     owner: "{{ item.owner | default('root') }}"
@@ -13,7 +13,7 @@
     - haproxy-certificates-create-directories
 
 - name: certificates | copy files
-  copy:
+  ansible.builtin.copy:
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
     owner: "{{ item.owner | default('root') }}"
@@ -26,7 +26,7 @@
     - haproxy-certificates-copy-files
 
 - name: certificates | remove files
-  file:
+  ansible.builtin.file:
     path: "{{ item.dest }}"
     state: absent
   with_items: "{{ haproxy_ssl_map }}"

tasks/configuration.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: configuration | warn or fail
-  fail:
+  ansible.builtin.fail:
     msg: "haproxy_global_nbproc is deprecated"
   ignore_errors: "{{ haproxy_version is version('2.5', '<') }}"
   when:
@@ -11,7 +11,7 @@
     - haproxy-configuration-warn-or-fail
 
 - name: configuration | update file
-  template:
+  ansible.builtin.template:
     src: "{{ haproxy_conf_template }}"
     dest: /etc/haproxy/haproxy.cfg
     owner: root

tasks/install.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: install | dependencies (pre)
-  apt:
+  ansible.builtin.apt:
     name: "{{ haproxy_dependencies_pre }}"
     state: "{{ apt_install_state | default('latest') }}"
     update_cache: true
@@ -10,23 +10,23 @@
     - haproxy-repository-install-dependencies
 
 - name: install | add repository from PPA and install its signing key
-  apt_repository:
+  ansible.builtin.apt_repository:
     repo: "{{ haproxy_ppa }}"
     update_cache: true
   when: haproxy_use_ppa | bool
   tags:
     - haproxy-install-add-repository
 
 - name: install | dependencies
-  apt:
+  ansible.builtin.apt:
     name: "{{ item.name }}"
     state: "{{ item.state }}"
   with_items: "{{ haproxy_dependencies }}"
   tags:
     - haproxy-install-dependencies
 
 - name: install | additional
-  apt:
+  ansible.builtin.apt:
     name: "{{ haproxy_install }}"
     state: "{{ apt_install_state | default('latest') }}"
   tags:

tasks/letsencrypt.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: letsencrypt | copy SSL deploy script
-  template:
+  ansible.builtin.template:
     src: "{{ haproxy_letsencrypt_ssl_deploy_template }}"
     dest: "{{ haproxy_letsencrypt_ssl_deploy }}"
     owner: root
@@ -11,7 +11,7 @@
     - haproxy-letsencrypt-ssl-deploy
 
 - name: letsencrypt | copy OCSP deploy script
-  template:
+  ansible.builtin.template:
     src: "{{ haproxy_letsencrypt_ocsp_deploy_template }}"
     dest: "{{ haproxy_letsencrypt_ocsp_deploy }}"
     owner: root
@@ -21,7 +21,7 @@
     - haproxy-letsencrypt-ocsp-deploy
 
 - name: letsencrypt | configure (cron) job for OCSP deploy
-  cron:
+  ansible.builtin.cron:
     name: haproxy-letsencrypt-ocsp-deploy
     job: "{{ haproxy_letsencrypt_ocsp_deploy }}"
     state: "{{ haproxy_letsencrypt_ocsp_deploy_job.state | default('absent') }}"

tasks/main.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: check version support
-  fail:
+  ansible.builtin.fail:
     msg: "HAProxy version {{ haproxy_version }} is not supported"
   when: haproxy_version | string not in haproxy_versions_supported
   tags:
@@ -40,7 +40,7 @@
     - haproxy-letsencrypt
 
 - name: start and enable service
-  service:
+  ansible.builtin.service:
     name: haproxy
     state: "{{ service_default_state | default('started') }}"
     enabled: "{{ service_default_enabled | default(true) | bool }}"