Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsus2 not parsing correctly #649

Open
geddski opened this issue Nov 28, 2023 · 2 comments
Open

Gsus2 not parsing correctly #649

geddski opened this issue Nov 28, 2023 · 2 comments

Comments

@geddski
Copy link

geddski commented Nov 28, 2023

Given the chord Gsus2, Chord Symbol returns normalized.isSuspended value false. Whereas Gsus4 has true. Seems like a bug, unless there's something in music theory I'm not understanding?

@no-chris
Copy link
Owner

Well it is actually the expected behaviour, because of the reference music theory material used during the writing of this lib: https://www.harrisonmusic.com/store/c11/Music_Theory_Books_Audio.html

Basically Mark Harrison explains that there is no such thing as a "sus2" chord, and suggests G(add9,omit3) notation instead. Of course this is not really practical and does not reflects the actual usages, which is why I also implemented the possibility to render as sus2 (see https://github.com/no-chris/chord-symbol/tree/master/packages/chord-symbol#rendering-and-normalization)

Now you could argue that given this possibility then it would make sense to have normalized.isSuspended set to true when enabling short namings and rendering a sus2 chord. I need to live with the idea for a while, it could be done quite easily I think.

@geddski
Copy link
Author

geddski commented Nov 30, 2023

Gotcha, thanks for the explanation! I'm using the parser but not the renderer, so in my case adding isSuspended to the parser would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants