Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's enable Temporal by default #57127

Open
jasnell opened this issue Feb 18, 2025 · 7 comments · May be fixed by #57128
Open

Let's enable Temporal by default #57127

jasnell opened this issue Feb 18, 2025 · 7 comments · May be fixed by #57128
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@jasnell
Copy link
Member

jasnell commented Feb 18, 2025

What is the problem this feature will solve?

The Temporal API is nearing completion in TC39 and is largely stable. It is not turned on by default in V8 just yet until it reaches stage 4 but platforms are starting to enable it by default. We ought to be able to go ahead and enable it by default in main

What is the feature you are proposing to solve the problem?

Enable Temporal by default but still marked as experimental

What alternatives have you considered?

No response

@jasnell jasnell added the feature request Issues that request new features to be added to Node.js. label Feb 18, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Feb 18, 2025
@ljharb
Copy link
Member

ljharb commented Feb 18, 2025

It would probably be wise to wait until it's been fully shipped unflagged on the web for a bit - maybe for node 25?

@jasnell
Copy link
Member Author

jasnell commented Feb 18, 2025

Either way. I'm going to prepare a PR but it's fine to let it sit for a bit

@jasnell jasnell linked a pull request Feb 18, 2025 that will close this issue
@aduh95
Copy link
Contributor

aduh95 commented Feb 19, 2025

On one hand, I can't wait for Temporal to be available, but on the other hand, I can wait and use the polyfill a while longer. So far the experience of enabling flagged features of V8 has been mixed (TLA was a success, the import assertions syntax not so much); given this is fully polifillable, I'm not sure it's worth the risks (although I reckon the risks are very mild at worst).

@targos
Copy link
Member

targos commented Feb 19, 2025

Can someone link to the tracking issue in V8 so we have some information on the progress of the implementation there?

@targos
Copy link
Member

targos commented Feb 19, 2025

I wonder if it passes the existing test262 tests for Temporal.

@aduh95
Copy link
Contributor

aduh95 commented Feb 19, 2025

@jasnell
Copy link
Member Author

jasnell commented Feb 19, 2025

Yep, I'm fine with waiting a bit but I wanted to at least get it on the radar here. I'm not in any rush to merge it. V8's test coverage on this is currently hovering around the 75% mark but that is expected to increase significantly in the coming couple of months. My current thinking is that we can let the PR sit and look at merging it still as experimental after 24.0.0 is cut in April with a flag to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js.
Projects
Status: Awaiting Triage
Development

Successfully merging a pull request may close this issue.

4 participants