From 550c9390bebca79397b36d7136bad41c43e1eac4 Mon Sep 17 00:00:00 2001
From: Carlos Espa <carlos.espa@nearform.com>
Date: Sun, 17 Nov 2024 10:12:01 +0100
Subject: [PATCH 1/5] doc: deprecate passing invalid types in fs.existsSync

---
 doc/api/deprecations.md | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 5d0940880fef31..82b0305dff9912 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -3772,6 +3772,19 @@ It is recommended to use the `new` qualifier instead. This applies to all REPL c
 
 <!-- md-lint skip-deprecation DEP0186 -->
 
+### DEP0187: `fs.existsSync` never throw on invalid arguments
+
+<!-- YAML
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55753
+    description: Documentation-only.
+-->
+
+Type: Documentation-only
+
+Passing invalid argument types is deprecated.
+
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3
 [RFC 8247 Section 2.4]: https://www.rfc-editor.org/rfc/rfc8247#section-2.4

From 024adecabde5a3515b31a067285db89487a189bb Mon Sep 17 00:00:00 2001
From: Carlos Espa <carlos.espa@nearform.com>
Date: Sun, 17 Nov 2024 10:14:01 +0100
Subject: [PATCH 2/5] fixup! doc: deprecate passing invalid types in
 fs.existsSync

---
 doc/api/deprecations.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 82b0305dff9912..41fba4c20b44e9 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -3777,7 +3777,7 @@ It is recommended to use the `new` qualifier instead. This applies to all REPL c
 <!-- YAML
 changes:
   - version: REPLACEME
-    pr-url: https://github.com/nodejs/node/pull/55753
+    pr-url: https://github.com/nodejs/node/pull/55892
     description: Documentation-only.
 -->
 

From dd8e44dfd513dd05088e77eba7f2ef8e2ae013b0 Mon Sep 17 00:00:00 2001
From: Carlos Espa <43477095+Ceres6@users.noreply.github.com>
Date: Wed, 20 Nov 2024 09:03:35 +0100
Subject: [PATCH 3/5] Update doc/api/deprecations.md

Co-authored-by: Aviv Keller <redyetidev@gmail.com>
---
 doc/api/deprecations.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 41fba4c20b44e9..41938f84113a9b 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -3772,7 +3772,7 @@ It is recommended to use the `new` qualifier instead. This applies to all REPL c
 
 <!-- md-lint skip-deprecation DEP0186 -->
 
-### DEP0187: `fs.existsSync` never throw on invalid arguments
+### DEP0187: Passing invalid arguments to `fs.existsSync`
 
 <!-- YAML
 changes:

From 9434bf15a19e2179abbb986fc3701e6ac655f291 Mon Sep 17 00:00:00 2001
From: Carlos Espa <43477095+Ceres6@users.noreply.github.com>
Date: Wed, 20 Nov 2024 10:01:17 +0100
Subject: [PATCH 4/5] Update doc/api/deprecations.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/deprecations.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 41938f84113a9b..b2764786318ed8 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -3772,7 +3772,7 @@ It is recommended to use the `new` qualifier instead. This applies to all REPL c
 
 <!-- md-lint skip-deprecation DEP0186 -->
 
-### DEP0187: Passing invalid arguments to `fs.existsSync`
+### DEP0187: Passing invalid argument types to `fs.existsSync`
 
 <!-- YAML
 changes:

From 390fc19295f39fae34141371e624ce2a6a172aa6 Mon Sep 17 00:00:00 2001
From: Carlos Espa <43477095+Ceres6@users.noreply.github.com>
Date: Wed, 20 Nov 2024 10:01:38 +0100
Subject: [PATCH 5/5] Update doc/api/deprecations.md

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
---
 doc/api/deprecations.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index b2764786318ed8..41e47b11a2d65f 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -3783,7 +3783,8 @@ changes:
 
 Type: Documentation-only
 
-Passing invalid argument types is deprecated.
+Passing non-supported argument types is deprecated and, instead of returning `false`,
+will throw an error in a future version.
 
 [NIST SP 800-38D]: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-38d.pdf
 [RFC 6066]: https://tools.ietf.org/html/rfc6066#section-3