Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use tabindex when href is not available #7269

Closed
wants to merge 1 commit into from
Closed

fix: use tabindex when href is not available #7269

wants to merge 1 commit into from

Conversation

bjohansebas
Copy link

Description

Since a button is being simulated in the bottom component, a tabindex is added to buttons that don't have an href so they can be selected with the keyboard

Related Issues

closes #7247

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bjohansebas bjohansebas requested a review from a team as a code owner November 20, 2024 23:19
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 20, 2024 11:20pm

@RedYetiDev RedYetiDev added the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.79% (631/695) 72.65% (186/256) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.385s ⏱️

bmuenzenmeyer
bmuenzenmeyer requested changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does hitting enter or spacebar work for anyone? this seems non-functional to me in

  • chrome
  • firefox

@bjohansebas
Copy link
Author

bjohansebas commented Nov 23, 2024 •
edited
Loading

Opps, it's not working because it's still a link. Maybe we should convert it into a real button instead of using it as a link

@bjohansebas
Copy link
Author

Really, I would like to help, but running Next.js is too heavy for my computer

@bmuenzenmeyer
Copy link
Collaborator

I'm sorry to hear this but understand. The project has plenty of reasons to choose the stack we have, but I acknowledge (and have argued against) the complexity it brings.

We'll continue to aim for a balance of accessibility and capability, and it's my goal to make it more than lip service.

@ovflowd
Copy link
Member

ovflowd commented Nov 26, 2024 •
edited
Loading

Really, I would like to help, but running Next.js is too heavy for my computer

I'm sorry to hear that. Could you tell me what exactly is too heavy? Is it consuming too much compute resources?

@bjohansebas
Copy link
Author

Yep, too many resources consumed by Next.js, which makes the computer really slow.

When I have more resources, I'll come back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer requested changes

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@RedYetiDev RedYetiDev RedYetiDev approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's impossible to navigate to "Copy to clipboard" button using keyboard
6 participants
@bjohansebas @bmuenzenmeyer @ovflowd @aymen94 @RedYetiDev @AugustinMauroy