Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplication of percentages #161

Open
Hendekagon opened this issue Mar 5, 2018 · 4 comments
Open

Multiplication of percentages #161

Hendekagon opened this issue Mar 5, 2018 · 4 comments

Comments

@Hendekagon
Copy link
Contributor

(percent* (percent 50) (percent 50))
=> #garden.types.CSSUnit{:unit :%, :magnitude 2500}
@noprompt
Copy link
Owner

@Hendekagon Can you elaborate?

@hkjels
Copy link

hkjels commented Mar 12, 2018

I guess a :magnitude of 25 would be the expected result

@noprompt
Copy link
Owner

@hkjels Thanks for parsing that one for me! A patch would be greatly appreciated. This definitely seems like unfavorable behavior.

@harold
Copy link
Collaborator

harold commented May 26, 2022

This appears to be fixed:

user=> (require 'garden.units)
nil
user=> (garden.units/percent* (garden.units/percent 50) (garden.units/percent 50))
#garden.types.CSSUnit{:unit :%, :magnitude 25}

c.f., 75c2a40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants