Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapText assignment of dy attribute #247

Closed
katiepark opened this issue Oct 6, 2017 · 2 comments
Closed

Fix wrapText assignment of dy attribute #247

katiepark opened this issue Oct 6, 2017 · 2 comments
Assignees

Comments

@katiepark
Copy link
Contributor

katiepark commented Oct 6, 2017

A one-line fix. The wrapText helper function needs to include the initial dy value in addition to any line height offset. It also needs to specify the unit of the value -- can be hard coded to pixels until #248 (handling of units) is closed.

@ghing
Copy link
Contributor

ghing commented Oct 6, 2017

Is this something that works sometimes, or that you have to fix each time you use it?

@katiepark
Copy link
Contributor Author

It works fine if there's no dy value initially set. I'm just about to push a fix to this that should work in either scenario, though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants