Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'save image' button dead on firefox? #54

Closed
dansinker opened this issue Jul 30, 2015 · 5 comments
Closed

'save image' button dead on firefox? #54

dansinker opened this issue Jul 30, 2015 · 5 comments

Comments

@dansinker
Copy link

in Quotable, when I hit "save image" either one of two things happens:

  1. I get a dialogue telling me my quote doesn't fit and to reduce the font size
  2. nothing

in safari (launched to check that I'm not nuts), #1 is still true (and works as expected), #2 opens a new window with the image.

@TylerFisher
Copy link
Contributor

Ah yikes, not sure when that bug came back. Electron runs Chromium, so I haven't been testing Firefox as rigorously as I should, but we've solved this issue before.

@TylerFisher
Copy link
Contributor

Oh ugh, SVG + Firefox + html2canvas don't play together. We use PNG assets on quotable/factlist for this reason. I should note that in the docs.

@TylerFisher
Copy link
Contributor

RE: the Safari issue, that's just what Safari does with data URIs, unfortunately. You can still save from that new tab.

@dansinker
Copy link
Author

Oh right, yes, I was pinging safari as the expected behavior.

On Thu, Jul 30, 2015 at 4:20 PM, Tyler Fisher [email protected]
wrote:

RE: the Safari issue, that's just what Safari does with data URIs,
unfortunately. You can still save from that new tab.


Reply to this email directly or view it on GitHub
#54 (comment).

@TylerFisher
Copy link
Contributor

Closing in favor of #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants