-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors render differently in Chrome and Safari #81
Comments
I have been wondering if we DO need to render these on a server of some sort. It still might not solve this fucking problem though. |
The other thing is getting consistent retina-quality versions. HTML2Canvas struggles with that one. |
@eads Those are the two things I'm kinda trying to figure out right now. I was paroozing @jemory's work on retina quality images earlier #58 and was maybe going to implement that. I wonder if there are other options besides HTML2Canvas for doing that kind of thing. Maybe it makes sense to just do everything in canvas from the beginning? I'm not sure if that would fix the color thing though. |
I also just took a look at the live version of Vox's meme tool and they seem to also have this same problem with colors rendering correctly when downloaded. http://apps.voxmedia.com/tools/meme/sbnation/ |
The color thing seems baked into the canvas implementation and squishiness around color space. I have a hard time imagining something other than HTML2Canvas (though there might be better implementations of the idea) that don't involve farming out the work to an external server/service. |
I've already implemented dom-to-image, which is a far cleaner pipeline, over here 34eb4d3. Same issue. |
This is the exact same version of quotable, with the exact same theme, running in two different browsers. I know I'm color blind, but those colors are not rendering the same.
A first Google suggests that maybe it has something to do with this https://bugs.chromium.org/p/chromium/issues/detail?id=425935:
The text was updated successfully, but these errors were encountered: