Add egs_brachy as a third-party submodule #907
Replies: 6 comments 2 replies
-
I'll write things down as I find them. Since our egs_brachy repo has the following structure:
we've modified the EGSnrc configure script to account for this structure. |
Beta Was this translation helpful? Give feedback.
-
Our custom |
Beta Was this translation helpful? Give feedback.
-
I see 96b9747 refers to Sobol and gzstream and points to this repo, which I had forgotten about. We were using that method to share those extras, before we decided to fork EGSnrc and distribute it with those extras already built-in + egs_brachy. |
Beta Was this translation helpful? Give feedback.
-
Note that the repo is slightly out of date since it changed the egsphant support to ndgeometry, but we didn't roll back this change when we rolled back the egsphant into egs_glib (due to the ramp file issue). See here. |
Beta Was this translation helpful? Give feedback.
-
Thanks for the details. I think we can include the missing bits, minding the copyright (some files say copyright NRC, but I think it ought to CRLP; anyways we can sort this out). I am not sure how to best go about the integration, I would like to establish a common method for all third-party contributions. I am debating over:
I prefer the second alternative, which from a user perspective could look something like:
Too technical? Requires git, but such steps could be abstracted inside an At any rate, food for thought. |
Beta Was this translation helpful? Give feedback.
-
@mchamberland we are currently teaching a course in Wisconsin, and @dworogers and I are talking about At any rate, will you have some time over the summer to help me out with this? I will write draft instructions, and we can go from there. Let's see how simple we can make it for end users of |
Beta Was this translation helpful? Give feedback.
-
@ftessier Let's move our discussion on how to include
egs_brachy
as a third-party submodule from #906 to here.First order of business for me will be to look at our CLRP repos and figure out where we're at and what EGSnrc modifications are needed by
egs_brachy
.Beta Was this translation helpful? Give feedback.
All reactions