Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Could not resolve './build/Release/ecdh' from ./build/Release/ecdh?commonjs-external #123

Open
jdnichollsc opened this issue Oct 12, 2022 · 0 comments

Comments

@jdnichollsc
Copy link

Hello folks, hope you're doing well

We're trying to run the below patch-package in order to support Buffer and process NodeJS variables with web3 packages such as web3auth:

diff --git a/node_modules/@remix-run/dev/compiler.js b/node_modules/@remix-run/dev/compiler.js
index 9ce96d5..9c000b0 100644
--- a/node_modules/@remix-run/dev/dist/compiler.js
+++ b/node_modules/@remix-run/dev/dist/compiler.js
@@ -18,7 +18,9 @@ var esbuild = require('esbuild');
 var fse = require('fs-extra');
 var debounce = require('lodash.debounce');
 var chokidar = require('chokidar');
-var nodeModulesPolyfill = require('@esbuild-plugins/node-modules-polyfill');
+var NodeGlobalsPolyfillPlugin = require('@esbuild-plugins/node-globals-polyfill').NodeGlobalsPolyfillPlugin;
+var NodeModulesPolyfillPlugin = require('@esbuild-plugins/node-modules-polyfill').NodeModulesPolyfillPlugin;
+
 var esbuildPluginPnp = require('@yarnpkg/esbuild-plugin-pnp');
 var build$1 = require('./build.js');
 var config = require('./config.js');
@@ -309,7 +311,7 @@ async function createBrowserBuild(config, options) {
     entryPoints[id] = config.routes[id].file + "?browser";
   }

-  let plugins = [urlImportsPlugin.urlImportsPlugin(), mdx.mdxPlugin(config), browserRouteModulesPlugin.browserRouteModulesPlugin(config, /\?browser$/), emptyModulesPlugin.emptyModulesPlugin(config, /\.server(\.[jt]sx?)?$/), nodeModulesPolyfill.NodeModulesPolyfillPlugin(), esbuildPluginPnp.pnpPlugin()];
+  let plugins = [NodeGlobalsPolyfillPlugin({buffer: true, process: true}), NodeModulesPolyfillPlugin(), urlImportsPlugin.urlImportsPlugin(), mdx.mdxPlugin(config), browserRouteModulesPlugin.browserRouteModulesPlugin(config, /\?browser$/), emptyModulesPlugin.emptyModulesPlugin(config, /\.server(\.[jt]sx?)?$/), esbuildPluginPnp.pnpPlugin()];
   return esbuild__namespace.build({
     entryPoints,
     outdir: config.assetsBuildDirectory,
@@ -359,7 +361,8 @@ function createServerBuild(config, options, assetsManifestPromiseRef) {
   let plugins = [urlImportsPlugin.urlImportsPlugin(), mdx.mdxPlugin(config), emptyModulesPlugin.emptyModulesPlugin(config, /\.client(\.[jt]sx?)?$/), serverRouteModulesPlugin.serverRouteModulesPlugin(config), serverEntryModulePlugin.serverEntryModulePlugin(config), serverAssetsManifestPlugin.serverAssetsManifestPlugin(assetsManifestPromiseRef), serverBareModulesPlugin.serverBareModulesPlugin(config, options.onWarning), esbuildPluginPnp.pnpPlugin()];

   if (config.serverPlatform !== "node") {
-    plugins.unshift(nodeModulesPolyfill.NodeModulesPolyfillPlugin());
+    plugins.unshift(NodeGlobalsPolyfillPlugin({buffer: true, process: true}));
+    plugins.unshift(NodeModulesPolyfillPlugin());
   }

   return esbuild__namespace.build({

It was running before but now I'm getting the below error when I try to build the project:

> nx run common:build

Bundling common...
Error during bundle: Error: Could not resolve './build/Release/ecdh' from ./build/Release/ecdh?commonjs-external
Bundle failed: common

 —————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Ran target build for project webapp and 2 task(s) it depends on (9s)
 
    ✖    1/2 failed
    ✔    1/2 succeeded [1 read from cache]

Do you have any idea about this error?

Thanks for your collaboration! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant