Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nx 20.x.x ESLint in neovim no longer can read tsconfig.base.json #30085

Closed
1 of 4 tasks
mikkurogue opened this issue Feb 18, 2025 · 2 comments
Closed
1 of 4 tasks

Comments

@mikkurogue
Copy link

Current Behavior

We upgraded to nx 20.4.4 from 19.8.4 and now we have an issue with eslint and specifically loading the eslint configuration (and tsconfig configuration) in neovim setups.

The error we get at the top of any file is:
eslint: Parsing error: Cannot read file '/Users/mikku/code/Work/apps/frontend/tsconfig.base.json'.

Howeverthe file is not named tsconfig.base.json per project, but just tsconfig.json and the root configuration file is called tsconfig.base.json in the root of the project.

I can however "get it to work" by renaming the projects tsconfig.json to tsconfig.base.json, opening a file and then reverting the rename. However this needs to happen everytime I would re-open neovim.

Expected Behavior

I expect in neovim that my eslint-lsp and vtsls (TS lsp) to attach and work correctly without throwing an error that it can not parse the configuration file named tsconfig.base.json within a project.

GitHub Repo

No response

Steps to Reproduce

  1. Have a project with nx version 19.8.4 installed, setup with a tsconfig.base.json and a project with a tsconfig.json
  2. upgrade nx to 20.4.4 along side the dependencies it requires
  3. In (neo)vim open a source buffer in the project and wait for LSP's to attach, this should then throw a diagnostic error that it can not read the configuration.

Nx Report

NX   Report complete - copy this into the issue template

Node           : 20.14.0
OS             : darwin-arm64
Native Target  : aarch64-macos
yarn           : 4.6.0

nx (global)            : 20.4.4
nx                     : 20.4.4
@nx/js                 : 20.4.4
@nx/jest               : 20.4.4
@nx/eslint             : 20.4.4
@nx/workspace          : 20.4.4
@nx/cypress            : 20.4.4
@nx/devkit             : 20.4.4
@nx/eslint-plugin      : 20.4.4
@nx/module-federation  : 20.4.4
@nx/nest               : 20.4.4
@nx/next               : 20.4.4
@nx/node               : 20.4.4
@nx/plugin             : 20.4.4
@nx/react              : 20.4.4
@nx/web                : 20.4.4
@nx/webpack            : 20.4.4
typescript             : 5.3.3
---------------------------------------
Registered Plugins:
@nx/eslint-plugin
---------------------------------------
Community plugins:
@nestjs/azure-storage  : 3.0.0
@nx-tools/nx-container : 6.0.4
---------------------------------------
Local workspace plugins:
         cube

Failure Logs

Package Manager Version

yarn @ 4.6.0

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

I'll be happy to provide more details if necessary, like the configurations etc.

@ryanbas21
Copy link
Contributor

FWIW i use neovim and have a 20.4.4 branch and my eslint works fine.

@mikkurogue
Copy link
Author

We decided to go nuclear and remove all configuration and just start again, now it works just fine again. Somehow the configuration was never correct it seems but just worked until we upgraded nx and the rest.

Closing the issue as it resolved itself by just creating a new configuration for eslint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants