Skip to content

Commit ece9d27

Browse files
committed
Add complete integration test for cloning from test EmptyNotebook
1 parent 02e9fb6 commit ece9d27

File tree

1 file changed

+38
-1
lines changed

1 file changed

+38
-1
lines changed

ci/integration.js

+38-1
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,39 @@ const main = async () => {
163163
nbformat_minor: 2
164164
};
165165

166+
const EmptyNotebook = {
167+
cells: [
168+
{
169+
cell_type: "code",
170+
execution_count: null,
171+
metadata: {},
172+
outputs: [],
173+
source: []
174+
}
175+
],
176+
metadata: {
177+
kernelspec: {
178+
display_name: "dev",
179+
language: "python",
180+
name: "dev"
181+
},
182+
language_info: {
183+
codemirror_mode: {
184+
name: "ipython",
185+
version: 3
186+
},
187+
file_extension: ".py",
188+
mimetype: "text/x-python",
189+
name: "python",
190+
nbconvert_exporter: "python",
191+
pygments_lexer: "ipython3",
192+
version: "3.6.8"
193+
}
194+
},
195+
nbformat: 4,
196+
nbformat_minor: 2
197+
};
198+
166199
await jupyterServer.writeNotebook(
167200
"ci-local-writeout.ipynb",
168201
originalNotebook
@@ -241,9 +274,10 @@ const main = async () => {
241274
checkS3CloneLandingResponse(s3CloneLandingRes, publishedPath);
242275

243276
await jupyterServer.cloneS3Notebook(bucketName, publishedPath);
277+
await jupyterServer.cloneFSNotebook("test_files/EmptyNotebook.ipynb");
244278
// Wait for minio to have the notebook
245279
// Future iterations of this script should poll to get the notebook
246-
await sleep(700);
280+
await sleep(2000);
247281

248282
await compareS3Notebooks("ci-published.ipynb", originalNotebook);
249283
await compareS3Notebooks("ci-local-writeout.ipynb", originalNotebook);
@@ -255,12 +289,15 @@ const main = async () => {
255289
save: 3
256290
}
257291
});
292+
await compareS3Notebooks("EmptyNotebook.ipynb", EmptyNotebook);
293+
258294
await sleep(700);
259295

260296
await jupyterServer.deleteNotebook("ci-published.ipynb");
261297
await jupyterServer.deleteNotebook("ci-local-writeout.ipynb");
262298
await jupyterServer.deleteNotebook("ci-local-writeout2.ipynb");
263299
await jupyterServer.deleteNotebook("ci-local-writeout3.ipynb");
300+
await jupyterServer.deleteNotebook("EmptyNotebook.ipynb");
264301

265302
jupyterServer.shutdown();
266303

0 commit comments

Comments
 (0)