Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer support #132

Closed
jberg opened this issue Jan 16, 2019 · 13 comments
Closed

Visualizer support #132

jberg opened this issue Jan 16, 2019 · 13 comments
Labels
enhancement This thread requests an enhancement to be implemented. feature proposal This issue describes a proposed feature that has not been implemented yet. Feedback is welcome.

Comments

@jberg
Copy link

jberg commented Jan 16, 2019

Hi, love what you are doing with this project.

I work on a port of the MilkDrop2 visualizer from Winamp to javascript: https://github.com/jberg/butterchurn

We have added support over at the Webamp project: https://webamp.org/

Would love to help add support for visualizations to Nuclear. Is this something that you would be interested in?

Thanks and awesome work on this project!

@jberg jberg changed the title Visualizer support? Visualizer support Jan 16, 2019
@nukeop nukeop added enhancement This thread requests an enhancement to be implemented. feature request This is a request for the addition of some feature. labels Jan 16, 2019
@nukeop
Copy link
Owner

nukeop commented Jan 16, 2019

Hey, if that's based on WebGL then I'm sure it can be added fairly easily. If you'd like to submit a pull request, you're more than welcome to, otherwise I'll try to add this myself at some point.

@jberg
Copy link
Author

jberg commented Jan 16, 2019

It is WebGL based.

I'll dig around the source some and see if I can get the visualizer attached and rendering.

Thanks!

@nukeop
Copy link
Owner

nukeop commented Jan 16, 2019

If you do that maybe you could try adding a new entry in the left-hand menu, create a new view for the visualizer and render it there.

@jberg
Copy link
Author

jberg commented Jan 16, 2019

Sounds good! I'll give that a try

@jberg
Copy link
Author

jberg commented Jan 17, 2019

Had a little time to look around the source a bit. I see that you are using react-sound which uses soundmanager2.

In order to do the WebGL visualizations we need to get access to the AudioNode that soundmanager2 is creating under the hood.

I'm not sure if react-sound is currently exposing access to soundmanager2.

So some small tasks we would need to do before moving forward:

  • Get access to soundmanager2 from react-sound
  • Access AudioNode's that soundmanager2 creates

I'll try to figure these out when I have a chance, but figured I would post what I had "learned" so far, in case you knew more or had time.

Thanks!

@dhannyz
Copy link

dhannyz commented Jan 17, 2019

@jberg this is awesome, is there somewhere i can have a chat with you about use of this on my own project, discord, slack, irc?

@jberg
Copy link
Author

jberg commented Jan 17, 2019

Thanks @dhannyz . You can reach me on the Webamp discord: https://discord.gg/VP3BxQ

@jberg
Copy link
Author

jberg commented Jan 17, 2019

I've created an issue over at react-sound to determine the best way to access the underlying soundmanager2 instance: leoasis/react-sound#75

@nukeop
Copy link
Owner

nukeop commented Jan 22, 2019

Adding something like this could be cool too: https://hackingbeauty.github.io/react-sound-display/
Either as an alternative visualizer or as a small widget somewhere (bottom bar maybe?).

@nukeop nukeop added feature proposal This issue describes a proposed feature that has not been implemented yet. Feedback is welcome. and removed feature request This is a request for the addition of some feature. labels Jan 22, 2019
@robotnealan
Copy link

@jberg Because react-sound uses SM2 under the hood you can still access the audio instance directly at window.soundManager.sounds, where window.soundManager.sounds[window.soundManager.soundIDs['0']] will automatically reference the current track playing.

@nukeop
Copy link
Owner

nukeop commented May 25, 2019

We don't use react-sound anymore now. It's been replaced with this: https://www.npmjs.com/package/react-sound-html5

@nukeop
Copy link
Owner

nukeop commented Feb 14, 2021

I know it took a long time, but it's finally in the newest release.

@nukeop nukeop closed this as completed Feb 14, 2021
@jberg
Copy link
Author

jberg commented Feb 14, 2021

🥳 🥳 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This thread requests an enhancement to be implemented. feature proposal This issue describes a proposed feature that has not been implemented yet. Feedback is welcome.
Projects
None yet
Development

No branches or pull requests

4 participants