Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-Ons Manager: Add button to Undo an Add-On Deletion #10016

Closed
elliott94 opened this issue Aug 1, 2019 · 7 comments
Closed

Add-Ons Manager: Add button to Undo an Add-On Deletion #10016

elliott94 opened this issue Aug 1, 2019 · 7 comments

Comments

@elliott94
Copy link

If a user accidentally removes an add-on from within the Add-Ons Manager, NVDA doesn't currently delete the add-on until it's restarted. If an add-on is accidentally remove by a user, would it be possible to add an "Undo" button to the Manager to tell NVDA that the package shouldn't be removed? From memory, Firefox offers something similar; if the "Undo" button is clicked before the browser restarts, extension data is retained and the extension remains.

@DrSooom
Copy link

DrSooom commented Aug 1, 2019

@elliott94: Please add the NVDA version to the issue description. Thanks.

Furthermore the devs must keep an eye regarding enabling/disabling add-ons as well when implementing such an undo feature.

@elliott94
Copy link
Author

Is the version still required - even for future enhancement requests? I assumed that the lack of build number would suggest that this wasn't implemented yet; apologies if this is considered useful info.

@DrSooom
Copy link

DrSooom commented Aug 1, 2019

Adding the NVDA version is always recommended due to historical reasons. In a few years you won't know which NVDA version was currently (in August 2019) the latest one.

@Adriani90
Copy link
Collaborator

cc: @hwf1324 maybe you could investigate this?

@hwf1324
Copy link
Contributor

hwf1324 commented Nov 11, 2024

cc: @hwf1324 maybe you could investigate this?

This Issue needs triage.

@Adriani90
Copy link
Collaborator

cc: @seanbudd, @SaschaCowley for triaging.

@seanbudd
Copy link
Member

Closing as won't fix - the assumption here "NVDA doesn't currently delete the add-on until it's restarted" is not entirely true. Once an add-on has been queued for removal it's in an unrecoverable state without reinstalling

@seanbudd seanbudd closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants