Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report the update of the selection when using Word selection extend / reduce commmands (f8 or shift+f8) #17424

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Nov 22, 2024

Link to issue number:

Partially fixes #3293.

Summary of the issue:

When using f8 (extend selection) or shift+f8 (reduce selection) in Word, the selection changes are not reported.

Description of user facing changes

When using f8 (extend selection) or shift+f8 (reduce selection) in Word, the selection changes will now be reported.
If the selection is extended / reduced at both ends, two consecutive selection update messages are reported, as done for control+a (select all).

Description of development approach

In WordDocument.initOverlayClass, bind script_caret_changeSelection to f8 and shift+f8, as already done for other gestures such as alt+shift+home or alt+shift+pageDown.

Testing strategy:

Manual test of f8 and shift+f8 in Word and Outlook, with and without UIA.
Test made on Windows 10, Word 2016 (Microsoft® Word 2016 MSO (Version 2410 Build 16.0.18129.20158) 32 bits).

Known issues with pull request:

This PR only reports selection change when f8/shift+f8 is pressed.

Though this PR does not fix the following issues:

  • "extend selection" mode" enabled or disabled upon first press on F8 or when pressing escape is not reported.
  • While in "extend selection mode", pressing left/right arrows reports the first character of the selection, what is unuseful, before reporting the selection change;

Since these issues were pre-existing to this PR, my opinion is that this PR is already an improvement of the "extend selection mode" usage with respect to what was occurring before.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79 CyrilleB79 marked this pull request as ready for review November 22, 2024 10:20
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner November 22, 2024 10:20
@CyrilleB79 CyrilleB79 requested a review from seanbudd November 22, 2024 10:20
@CyrilleB79
Copy link
Collaborator Author

@burmancomp I have received a message via e-mail regarding this PR, but it does not appears here, on the GitHub page of this PR. Have you removed it?

If this PR is not working for you, could you provide a debug log? If it finally also works, just let me know.

@burmancomp
Copy link
Contributor

Yes it works for me. My comment which I removed based on my missunderstanding of f8/shift+f8 functionality. Sorry.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 5d81cd2 into nvaccess:master Nov 26, 2024
5 checks passed
@github-actions github-actions bot added this to the 2025.1 milestone Nov 26, 2024
@CyrilleB79 CyrilleB79 deleted the wordExtendSelection branch November 26, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft Word, Shift + F3 and F8, NVDA Doesn't Read Selected Text
3 participants