Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated function tbl_flatten #259

Open
clason opened this issue Sep 2, 2024 · 2 comments · May be fixed by #275
Open

Remove deprecated function tbl_flatten #259

clason opened this issue Sep 2, 2024 · 2 comments · May be fixed by #275
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@clason
Copy link

clason commented Sep 2, 2024

In Nvim 0.10, vim.tbl_flatten was deprecated in favor of vim.iter(...):flatten().totable() (see :checkhealth vim.deprecated warning after using the plugin). You can either add a backward compatibility shim that checks for vim.iter, or just raise the minimum version to Nvim 0.10.

(On a related note, I'd suggest explicitly stating the minimum supported Neovim version in the Readme.)
@clason clason added enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2024
This was referenced Sep 3, 2024
Closed
Open
@delphinus
Copy link
Member

The upstream telscope's issue seems not to be processed. I start to think remove these deprecation warnings by bumping up this plugin's minimal requirements to v0.10.0.

@delphinus delphinus linked a pull request Nov 26, 2024 that will close this issue
Draft
@delphinus
Copy link
Member

telescope.nvim still have not remove 0.9 support. In advance I will do it for telescope-frecency in #275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: remove 0.9 support nvim-telescope/telescope-frecency.nvim
2 participants
@delphinus @clason