Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: implement Bounded VNDF Sampling #74

Open
tigrazone opened this issue Nov 17, 2024 · 2 comments
Open

Feature request: implement Bounded VNDF Sampling #74

tigrazone opened this issue Nov 17, 2024 · 2 comments

Comments

@tigrazone
Copy link

this is pdf file Kenta Eto and Yusuke Tokuyoshi. 2023. Bounded VNDF Sampling for Smith-GGX Reflections with code.

I implemented hvd_ggx_sample_vndf() equivalent of proposed method but I cant understand how to implement pdf calculation function equivalent.
Please help
@NBickford-NV
Copy link
Contributor

Hi @tigrazone ! I'm working on this internally; as you mentioned, the tricky thing is implementing the PDF correctly. We'll have an update to nvpro_core with this soon. Thank you!

@tigrazone
Copy link
Author

I implemented it in one reaytracer and make some optimizations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tigrazone @NBickford-NV