Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NW2 issue] : Setting two binded windows to a fullscreen state doesn't work anymore #7368

Closed
DimPaDev opened this issue Feb 10, 2020 · 2 comments

Comments

@DimPaDev
Copy link

NWJS Version : 0.44.0
Operating System : Linux (Fedora 31, both kde and gnome), Windows 10

Expected behavior

When you bind two windows both in size and position you should be able also to set these two windows to a fullscreen state just like in nw1 mode (--disable-features=nw2).

nw1fullscreen

Actual behavior

In Nw2 mode trying to set two binded windows to a fullscreen state results in a weird flickering issue which prevents the application to work normally.

nw2fullscreen

How to reproduce

Demo : nw2-fullscreen-two-windows-bug.zip

@DimPaDev
Copy link
Author

As it is a blocking issue I will reference this to #7230

@DimPaDev DimPaDev changed the title [NW2 issue] : Setting two binded windows fullscreen doesn't work anymore [NW2 issue] : Setting two binded windows to a fullscreen state doesn't work anymore Feb 10, 2020
@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Note that restore need to be handled as well. It should be fired when exiting fullscreen, not resized event. That's an issue in nw1 mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants