fix: handle more cache directives

Author: ronag

lib/interceptor/cache.js

@@ -42,20 +42,26 @@ class CacheHandler extends DecoratorHandler {
       return super.onHeaders(statusCode, headers, resume)
     }
 
-    const cacheControl = parseCacheControl(headers['cache-control'])
+    const cacheControlDirectives = parseCacheControl(headers['cache-control']) ?? {}
+
+    if (this.#key.headers.authorization && !cacheControlDirectives.public) {
+      return super.onHeaders(statusCode, headers, resume)
+    }
+
+    if (cacheControlDirectives.private || cacheControlDirectives['no-store']) {
+      return super.onHeaders(statusCode, headers, resume)
+    }
+
     if (
-      !cacheControl ||
-      !cacheControl.public ||
-      cacheControl.private ||
-      cacheControl['no-store'] ||
-      // TODO (fix): Support all cache control directives...
-      // cacheControl['no-transform'] ||
-      cacheControl['no-cache'] ||
-      cacheControl['must-understand'] ||
-      cacheControl['must-revalidate'] ||
-      cacheControl['proxy-revalidate']
+      cacheControlDirectives['no-transform'] ||
+      cacheControlDirectives['must-revalidate'] ||
+      cacheControlDirectives['proxy-revalidate'] ||
+      cacheControlDirectives['must-understand'] ||
+      cacheControlDirectives['stale-while-revalidate'] ||
+      cacheControlDirectives['stale-if-error'] ||
+      cacheControlDirectives['no-cache']
     ) {
-      // Not cacheble...
+      // TODO (fix): Support all cache control directives...
       return super.onHeaders(statusCode, headers, resume)
     }
 
@@ -76,9 +82,9 @@ class CacheHandler extends DecoratorHandler {
       return super.onHeaders(statusCode, headers, resume)
     }
 
-    const ttl = cacheControl.immutable
+    const ttl = cacheControlDirectives.immutable
       ? 31556952
-      : Number(cacheControl['s-max-age'] ?? cacheControl['max-age'])
+      : Number(cacheControlDirectives['s-max-age'] ?? cacheControlDirectives['max-age'])
     if (!ttl || !Number.isFinite(ttl) || ttl <= 0) {
       return super.onHeaders(statusCode, headers, resume)
     }
@@ -92,8 +98,8 @@ class CacheHandler extends DecoratorHandler {
       statusCode,
       statusMessage: '',
       headers,
-      cacheControlDirectives: '',
-      etag: '',
+      cacheControlDirectives,
+      etag: headers.etag,
       vary,
       cachedAt,
       staleAt: 0,
@@ -134,16 +140,17 @@ export default () => (dispatch) => (opts, handler) => {
     return dispatch(opts, handler)
   }
 
-  if (opts.headers?.['cache-control'] || opts.headers?.authorization) {
+  const cacheControlDirectives = parseCacheControl(opts?.headers['cache-control']) ?? {}
+
+  if (
+    cacheControlDirectives['max-age'] ||
+    cacheControlDirectives['max-stale'] ||
+    cacheControlDirectives['min-fresh'] ||
+    cacheControlDirectives['no-cache'] ||
+    cacheControlDirectives['no-transform'] ||
+    cacheControlDirectives['stale-if-error']
+  ) {
     // TODO (fix): Support all cache control directives...
-    // const cacheControl = cacheControlParser.parse(opts.headers['cache-control'])
-    // cacheControl['no-cache']
-    // cacheControl['no-store']
-    // cacheControl['max-age']
-    // cacheControl['max-stale']
-    // cacheControl['min-fresh']
-    // cacheControl['no-transform']
-    // cacheControl['only-if-cached']
     return dispatch(opts, handler)
   }
 
@@ -152,10 +159,12 @@ export default () => (dispatch) => (opts, handler) => {
 
   const store = opts.cache.store ?? DEFAULT_STORE
   const entry = store.get(opts)
-  if (!entry) {
+  if (!entry && !cacheControlDirectives['only-if-cached']) {
     return dispatch(
       opts,
-      new CacheHandler(undici.util.cache.makeCacheKey(opts), { store, handler }),
+      cacheControlDirectives['no-store']
+        ? handler
+        : new CacheHandler(undici.util.cache.makeCacheKey(opts), { store, handler }),
     )
   }
 
@@ -174,7 +183,7 @@ export default () => (dispatch) => (opts, handler) => {
     }
   }
 
-  const { statusCode, headers } = entry
+  const { statusCode, headers } = entry ?? { statusCode: 504, headers: {} }
   try {
     handler.onConnect(abort)
     if (aborted) {