Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message id to service-provider request/response, without it we can't currently match response with request #3541

Open
octol opened this issue Jun 12, 2023 · 0 comments

Comments

@octol
Copy link
Contributor

octol commented Jun 12, 2023

Currently in e.g nym-nr-query we guess the matching request for each response by trying to be synchronous, but this is fragile and you can easily end up where you display the wrong response for the request

Either we add this to the top-level Request, or if we don't need it for general service provider specific messages, add it into ControlRequest (and also Socks5RequestContent)

@octol octol converted this from a draft issue Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

1 participant