Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding track changes in tinymce 4.4.3 #128

Open
Rahul-Bisht opened this issue Sep 22, 2016 · 1 comment
Open

adding track changes in tinymce 4.4.3 #128

Rahul-Bisht opened this issue Sep 22, 2016 · 1 comment

Comments

@Rahul-Bisht
Copy link

Rahul-Bisht commented Sep 22, 2016

some of the methods are removed from tinymce 4.4.3 e.g 'onEvent', so i did some workaround for these events to fire. i am facing below issues with track changes though.

  • if i use Delete key then it is spiking one character e.g 'tiny' becomes 'tin' however Backspace key works fine.
  • if i keep both Delete & Backspace key pressed it spiking characters & removing some of the data.
  • i am unable to bind 'onNodeChange' event with new tinymce.

note - tinymce/plugins/ice/js/editor_plugin.js

@Rahul-Bisht
Copy link
Author

Rahul-Bisht commented Sep 23, 2016

  • i've changed element:ed.getBody() to
    element:ed.getWin().document.documentElement, and it works fine as expected, however it changes the font of entire html document.
  • keeping ed.getBody() makes its working weird as mentioned in original issue.

changeEditor = new ice.InlineChangeEditor({ element:ed.getWin().document.documentElement, //ed.getBody(), isTracking: self.isTracking, contentEditable: self.contentEditable, changeIdAttribute: self.changeIdAttribute, userIdAttribute: self.userIdAttribute, userNameAttribute: self.userNameAttribute, timeAttribute: self.timeAttribute, handleEvents:true, currentUser: { id: self.user.id, name: self.user.name }, plugins: [ 'IceEmdashPlugin', 'IceAddTitlePlugin', 'IceSmartQuotesPlugin', { name: 'IceCopyPastePlugin', settings: { pasteType: 'formattedClean', preserve: self.preserveOnPaste, beforePasteClean: self.beforePasteClean, afterPasteClean: self.afterPasteClean } } ], changeTypes: { insertType: { tag: self.insertTag, alias: self.insertClass }, deleteType: { tag: self.deleteTag, alias: self.deleteClass } } }).startTracking();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant