Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor witness interpreter o1vm #3062

Open
marcbeunardeau88 opened this issue Feb 25, 2025 · 0 comments
Open

Refactor witness interpreter o1vm #3062

marcbeunardeau88 opened this issue Feb 25, 2025 · 0 comments

Comments

@marcbeunardeau88
Copy link
Contributor

Currently the witness interpreter state is partially reset at each vm step to provide one line of the witness matrix at a time
This lead to unnatural things such as : some part of the state are permananent, other not, we build a matrix line by line in the main, we allocate one by one, the batch inversion is done separately etc...

I'd like to propose a new api where a witness interpreter env allocate the whole matrix and fill it
Then some pieces of code such as the construction of prrof input, the lookup state padding, the batch inversion could be done here, and not scattered all over the place

In the same PR we cna change the lookup state to be array, not vec, to be consistent with the rest of the state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant