Skip to content

Propose Go 1.23 as minimum required version due to getkin/kin-openapi dependency changes #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uh-zz opened this issue May 13, 2025 · 0 comments

Comments

@uh-zz
Copy link

uh-zz commented May 13, 2025

Overview

I would like to propose updating the minimum required Go version to 1.23 due to updates in getkin/kin-openapi.
#20

I have confirmed that tests are failing in the above CI because Go 1.20 doesn't support the toolchain.

I've also confirmed that oapi-codegen/oapi-codegen will address this soon:
oapi-codegen/oapi-codegen#1890

Why

In the following version of getkin/kin-openapi, the dependency invopop/yaml was removed:
https://github.com/getkin/kin-openapi/releases/tag/v0.129.0

As a result, I've confirmed that when importing both the latest version of getkin/kin-openapi and oapi-codegen/echo-middleware on the host side, the IDE shows errors.

go.mod

module path/to/module

go 1.24.3

require (
	github.com/getkin/kin-openapi v0.132.0
	github.com/go-playground/validator v9.31.0+incompatible
	github.com/labstack/echo/v4 v4.13.3
	github.com/oapi-codegen/echo-middleware v1.0.2
	github.com/oapi-codegen/oapi-codegen/v2 v2.4.1
	github.com/oapi-codegen/runtime v1.1.1
)

require (
	github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect
	github.com/dprotaso/go-yit v0.0.0-20220510233725-9ba8df137936 // indirect
	github.com/go-openapi/jsonpointer v0.21.0 // indirect
	github.com/go-openapi/swag v0.23.0 // indirect
	github.com/go-playground/locales v0.14.1 // indirect
	github.com/go-playground/universal-translator v0.18.1 // indirect
	github.com/google/uuid v1.5.0 // indirect
	github.com/gorilla/mux v1.8.1 // indirect
	github.com/josharian/intern v1.0.0 // indirect
	github.com/labstack/gommon v0.4.2 // indirect
	github.com/leodido/go-urn v1.2.4 // indirect
	github.com/mailru/easyjson v0.7.7 // indirect
	github.com/mattn/go-colorable v0.1.13 // indirect
	github.com/mattn/go-isatty v0.0.20 // indirect
	github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 // indirect
	github.com/oasdiff/yaml v0.0.0-20250309154309-f31be36b4037 // indirect
	github.com/oasdiff/yaml3 v0.0.0-20250309153720-d2182401db90 // indirect
	github.com/perimeterx/marshmallow v1.1.5 // indirect
	github.com/rogpeppe/go-internal v1.14.1 // indirect
	github.com/speakeasy-api/openapi-overlay v0.9.0 // indirect
	github.com/valyala/bytebufferpool v1.0.0 // indirect
	github.com/valyala/fasttemplate v1.2.2 // indirect
	github.com/vmware-labs/yaml-jsonpath v0.3.2 // indirect
	golang.org/x/crypto v0.31.0 // indirect
	golang.org/x/mod v0.21.0 // indirect
	golang.org/x/net v0.33.0 // indirect
	golang.org/x/sync v0.10.0 // indirect
	golang.org/x/sys v0.28.0 // indirect
	golang.org/x/text v0.21.0 // indirect
	golang.org/x/time v0.8.0 // indirect
	golang.org/x/tools v0.26.0 // indirect
	gopkg.in/go-playground/assert.v1 v1.2.1 // indirect
	gopkg.in/yaml.v2 v2.4.0 // indirect
	gopkg.in/yaml.v3 v3.0.1 // indirect
)

Error Messge

error while importing github.com/getkin/kin-openapi/openapi3: code in directory /path/to/vendor/github.com/oasdiff/yaml expects import "github.com/invopop/yaml"compiler

I have confirmed that compilation executes without issues despite the IDE error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant