New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeProxyTx is not tested #6

Open

bennetyee opened this issue Oct 2, 2024 · 0 comments

bennetyee commented Oct 2, 2024

kmaas/contracts/Account.sol

Line 100 in a4b924c

function makeProxyTx(

the original version in sapphire-paratime is tested at https://github.com/oasisprotocol/sapphire-paratime/blob/7e252fb1b6018e0536fe5bfa98bc788c2f856751/examples/onchain-signer/test/CommentBox.ts#L75 but if the two versions diverges in the future, that test coverage will not (continue to) extend to this version.

rishibalakrishnan mentioned this issue

Fix issues for security audit #9

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment