Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block proposer API #788

Open
pro-wh opened this issue Oct 23, 2024 · 1 comment
Open

Update block proposer API #788

pro-wh opened this issue Oct 23, 2024 · 1 comment
Labels
api-layer API layer-related issues.

Comments

@pro-wh
Copy link
Collaborator

pro-wh commented Oct 23, 2024

  1. Can we add proposer and signers props to block details endpoint https://nexus.oasis.io/v1/consensus/blocks/{height}? Props were added to blocks list endpoint in consensus: save block metadata #646 and we need to show the same data in block details page.

  2. Can we define type for entity_metadata so it is not unknown ?

expected type is

interface EntityMetadata {
  v: number
  serial: number
  name?: string
  url?: string
  email?: string
  keybase?: string
  twitter?: string
}

based on comment:
When available, it is an object with some subset of the following fields:

  • v: The version of the metadata structure (always present).
  • serial: The serial number of the metadata statement (always present).
  • name: The name of the entity.
  • url: The URL associated with the entity.
  • email: The email address associated with the entity.
  • keybase: Tne entity's keybase.io handle.
  • twitter: The twitter handle associated with the entity.
@ptrus
Copy link
Member

ptrus commented Dec 20, 2024

Can we add proposer and signers props to block details endpoint

This was done.

Can we define type for entity_metadata so it is not unknown ?

We could, but we don't enforce the type in the DB level so I'm not sure if we should do it in the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-layer API layer-related issues.
Projects
None yet
Development

No branches or pull requests

2 participants