-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake,lib,base: Export obs-websocket-api as a target #1196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Looks good to me, just curious if Pat has any comments on doing this |
This PR, the updated CMake of the obs-browser-api PR and the obs-studio PR that they rely on were based on a discussion I had with Pat about shipping those headets.
So for the 3 PRs, I'm waiting for Pat's feedback.
|
PatTheMav
reviewed
Jan 16, 2024
PatTheMav
reviewed
Jan 16, 2024
PatTheMav
reviewed
Jan 16, 2024
PatTheMav
reviewed
Jan 16, 2024
PatTheMav
reviewed
Jan 16, 2024
tytan652
force-pushed
the
install-api-header
branch
2 times, most recently
from
January 16, 2024 19:19
726dc92
to
aac9ace
Compare
tytan652
force-pushed
the
install-api-header
branch
4 times, most recently
from
January 27, 2024 13:09
11f0f7f
to
89ef42d
Compare
PatTheMav
approved these changes
Jan 27, 2024
PatTheMav
reviewed
Jan 27, 2024
8 tasks
tytan652
force-pushed
the
install-api-header
branch
from
January 27, 2024 16:51
89ef42d
to
6c08661
Compare
This enables the installation of the header in the include directory
tytan652
force-pushed
the
install-api-header
branch
from
March 30, 2024 11:58
6c08661
to
a477945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relies on:
This enables the installation of the header in the include directory by exporting it as an interface target
Motivation and Context
No more copy-pasting the header to use it
How Has This Been Tested?
Tested OS(s):
Windows and macOS headers needs to be checked
--component Development
adds the headerTypes of changes
Checklist:
master
or arelease/*
branch.