Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake,lib,base: Export obs-websocket-api as a target #1196

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

tytan652
Copy link
Contributor

@tytan652 tytan652 commented Jan 13, 2024

Description

Relies on:

This enables the installation of the header in the include directory by exporting it as an interface target

Motivation and Context

No more copy-pasting the header to use it

How Has This Been Tested?

Tested OS(s):

  • Arch Linux

Windows and macOS headers needs to be checked

  • Tested on Windows, --component Development adds the header

Types of changes

  • Other Enhancement (anything not applicable to what is listed)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

@tt2468
Copy link
Member

tt2468 commented Jan 15, 2024

Looks good to me, just curious if Pat has any comments on doing this

@tytan652
Copy link
Contributor Author

tytan652 commented Jan 15, 2024 via email

CMakeLists.txt Outdated Show resolved Hide resolved
lib/CMakeLists.txt Outdated Show resolved Hide resolved
lib/CMakeLists.txt Outdated Show resolved Hide resolved
@tytan652 tytan652 force-pushed the install-api-header branch 2 times, most recently from 726dc92 to aac9ace Compare January 16, 2024 19:19
@tytan652 tytan652 force-pushed the install-api-header branch 4 times, most recently from 11f0f7f to 89ef42d Compare January 27, 2024 13:09
@tytan652 tytan652 requested a review from PatTheMav January 27, 2024 13:10
This enables the installation of the header in the include directory
@tytan652 tytan652 force-pushed the install-api-header branch from 6c08661 to a477945 Compare March 30, 2024 11:58
@tt2468 tt2468 merged commit c8cf2d9 into obsproject:master Mar 31, 2024
1 check passed
@tytan652 tytan652 deleted the install-api-header branch March 31, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants