Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Community Page #1270

Open
patricoferris opened this issue Mar 12, 2021 · 9 comments
Open

Improve the Community Page #1270

patricoferris opened this issue Mar 12, 2021 · 9 comments

Comments

@patricoferris
Copy link
Contributor

There are a few little issues with the community page that I think need tweaking.

  1. The meetings are hardcoded and reference meetings in 2013! As a simple fix, these could be updated to the latest three meetings (probably the OCaml workshops). The fr version also includes dates whilst the en version doesn't. I think the dates look good.
  2. The OCaml around the Web section could be a little neater (e.g. same size images). I'm also open to any layout improvements too.

@Kanak1081 would you be interested in this issue as part of #1245, let me know either way below please :))

@Kanak1081
Copy link

@patricoferris Thank you so much for assigning me this task. I would definitely give it a try.

@Kanak1081
Copy link

Hey @patricoferris, I have worked on 2.) and made the icons symmetrical and of same size. End result looks something like this. I have also created a PR for the same and it has passed deployability checks.
I would be happy to know your suggestions for improving it more !
Screenshot (681)
Screenshot (682)

@Kanak1081
Copy link

Kanak1081 commented Mar 14, 2021

There are a few little issues with the community page that I think need tweaking.

  1. The meetings are hardcoded and reference meetings in 2013! As a simple fix, these could be updated to the latest three meetings (probably the OCaml workshops). The fr version also includes dates whilst the en version doesn't. I think the dates look good.

Hey @patricoferris I am unclear about this part, Do you want me to replace meetings with OCaml workshops? If yes, can you please let me know, from where shall I get the list of latest 3 OCaml workshops?
Yes, the 'en' version doesn't include the dates. I have found the issue and fixed it.
Thanks !

@patricoferris
Copy link
Contributor Author

Hi @Kanak1081 -- great work so far :))

Yes I should have been clearer - the full list of meetings can be found on https://ocaml.org/meetings/ (in the code it is https://github.com/ocaml/ocaml.org/blob/master/site/meetings/index.md). I just meant using the latest three events from that list instead of ones from a longer time ago. Hopefully that clears things up?

@Kanak1081
Copy link

Thanks @patricoferris :) for your kind help. I have made certain commits for updating the community page on the above mentioned issues by you. I have updated the OCaml meetings in Community page with the latest three and styled them. Please have a look at the end results in different screen sizes. I would be happy to know your suggestions.
I hope the issues raised by you in #1270 are cleared. Its great contributing for OCaml. I will be happy to take more issues like this.
Screenshot (699)
Screenshot (700)
Screenshot (701)

Thanks :)

@DivyanshiSingh
Copy link

Hey @patricoferris can I take up this issue?

@patricoferris
Copy link
Contributor Author

Hi @DivyanshiSingh,

@Kanak1081 is currently working on this and there is a PR open for it ocaml/ocaml.org#1272.

@gs0510
Copy link

gs0510 commented Apr 9, 2021

Hi @Kanak1081, I saw that you closed your PR, do you still want to work on this? Thanks! :)

@Deek9399
Copy link

Hello @gs0510, I was unaware of this issue and created a new issue #1537 which seems to be a small part of this issue.
Can I work on this issue if it is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants