-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter email list to not show unsubscribe
emails.
#1513
Comments
@Ndipbanyan since you were looking for a medium issue, you can go ahead and work on this one. |
@gs0510 Alright. Thank you. I will begin working on it and reach out for any help or clarifications that I might need. |
@Ndipbanyan Have you been able to make any progress? Do you have any questions? Thanks! |
@gs0510 I have been able to find the code that generates this list in the rss2.html in the script directory and I am trying to understand the function that does that to see if I can modify it to filter the list. So the drawback I am currently having is my little to lack of understanding of the Ocaml language. However, I am still going through tutorials to catch up. |
okay, let me know if you run into any problems! Thanks! |
@gs0510 So I came up with a solution and want to clear be about it before creating a PR. Let me try to explain- The api that is 'consumed' to display the emails in generated from Looking at the above, you will notice that the item with the title This has become rather too long :). However, the point of all my explanations is to be sure if my implementation is the way it should be or you mean an entirely different thing. Thank you for taking time in helping me with this. |
HI @Ndipbanyan! You are almost right :) We don't want to display the threads that say unsubscribe on the email feed and not remove Let me know if anything is unclear, or if there's anything OCaml related that you don't understand :) |
Thank you @gs0510 for the clarity. I will look into implementing this and let you know when I run into any issue understanding anything. Thanks |
@gs0510 I have been having issues in trying to run Please can you help me detect what the problem is? |
@Ndipbanyan Both errors are related to
|
The website doesn't work with the latest version of OMD, see issue #1321, you need to downgrade omd to 1.3.1 and it should be okay after that :) |
Yes! It works now. Thanks. Got me stuck there for a while. |
Also I think I have been able to filter the emails now. My implementation is thus:- Before:After:Code snippet (lines 592 and 614) |
This looks good @Ndipbanyan, you can make the regex case agnostic so that all kinds of unsubscribes are filtered out. You should also open a PR. :) |
Great! I've opened a PR. I used |
On the https://ocaml.org/community/ page, the recent email threads show all emails sent to the list. Filter the list so that
unsubscribe
emails are not displayed.The text was updated successfully, but these errors were encountered: