Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wagtail-favicon in requirements.txt #10

Open
ServiceInfo3CGS opened this issue Sep 14, 2023 · 1 comment
Open

wagtail-favicon in requirements.txt #10

ServiceInfo3CGS opened this issue Sep 14, 2023 · 1 comment

Comments

@ServiceInfo3CGS
Copy link

Hello, I used favicon in my project and it worked fine, but when I tried to pull the project from scratch on another machine migrations didnt workd. I had to comment all favicon relatives, then migrate once, then uncomment.

I am newb in python so, I am sorry for :

  1. Not beeing sure if I did something wrong so maybe it's my big fault.
  2. Not beeing able to help on this issue, all I can say right now is that (I think) it looks like a circular dependency between favicon and wagtail images.

regards.

@Makhnov
Copy link

Makhnov commented Sep 19, 2023

One solution could be to replace the 16>18 lines in "wagtail_favicon/migrations/0001_initial.py" :

replace this :

    dependencies = [
        ('wagtailcore', '0040_page_draft_title'),
    ]

by this :

    dependencies = [
        ('wagtailcore', '0040_page_draft_title'),
        ("wagtailimages", "0025_alter_image_file_alter_rendition_file"),
    ]

or this should be enough (?) :

    dependencies = [
        ("wagtailimages", "0025_alter_image_file_alter_rendition_file"),
    ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants