Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve httpRequest structured log entry #25

Open
thclark opened this issue Mar 27, 2023 · 0 comments
Open

Improve httpRequest structured log entry #25

thclark opened this issue Mar 27, 2023 · 0 comments
Labels
feature A new feature of the app good first issue A good first issue for new or junior developers help wanted Applied by the assigned developer if they need help

Comments

@thclark
Copy link
Contributor

thclark commented Mar 27, 2023

Feature request

Use Case

Basic httpRequest information is added to the GoogleStructuredLogHandler. However, this data could be much richer, as many fields are missing.

Current state

Inspecting the record.request object in the test server gives me a socket connection, not an HTTPRequest object. I don't know why; there's no ASGI server set up or anything and the same happens in debug and production mode. If anyone cares to:

  • solve this and get more http information out of the logs emitted by django.server, or
  • replace django.server with specific middleware to log detailed request information,

Especially if at the same time you:

  • do something smart about spans and traces to get much fuller information in

... then PRs are most welcome!

@thclark thclark added feature A new feature of the app good first issue A good first issue for new or junior developers help wanted Applied by the assigned developer if they need help labels Aug 4, 2023
@thclark thclark moved this to Percolating in Octue Board Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature of the app good first issue A good first issue for new or junior developers help wanted Applied by the assigned developer if they need help
Projects
Status: Percolating
Development

No branches or pull requests

1 participant