[IMP] estate: chapter15 - corrected code after review

- Removed un necessary assert (for the unused imports in the __init__ files)
- Renamed looping variables' names for better readability (property instead of record, and offer instead of record)
- Added auto_install property to True in the estate_account link module (used to auto install dependencies when we install estate_account)

Author: abeg-odoo

estate/__manifest__.py

@@ -1,5 +1,11 @@
 {
     'name': 'Estate',
+    'summary': "Module to manage properties",
+    'description': """
+This module is used to manage any type of properties and also to manage the selling pipeline for each property
+    """,
+    'author': 'Odoo',
+    'version': '1.0',
     'depends': ['base'],
     'application': True,
     'license': 'LGPL-3',

estate/models/__init__.py

@@ -3,9 +3,3 @@
 from . import estate_property_tag
 from . import estate_property_offer
 from . import res_users
-
-assert estate_property
-assert estate_property_type
-assert estate_property_tag
-assert estate_property_offer
-assert res_users

estate/models/estate_property.py

@@ -1,11 +1,11 @@
-from odoo import api, models, fields
-from odoo.exceptions import UserError, ValidationError
 from dateutil.relativedelta import relativedelta
 
+from odoo import _, api, models, fields
+from odoo.exceptions import UserError, ValidationError
 from odoo.tools.float_utils import float_compare, float_is_zero
 
 
-def _default_date_availability():
+def _default_date_availability(_):
     return fields.Date.today() + relativedelta(months=3)
 
 
@@ -22,7 +22,7 @@ class EstateProperty(models.Model):
     postcode = fields.Char()
     date_availability = fields.Date(
         copy=False,
-        default=_default_date_availability()
+        default=_default_date_availability
     )
     state = fields.Selection(
         string='Status',
@@ -70,46 +70,46 @@ def group_by_empty(self, types, domain):
         return types.search([])  # this is equivalent to return self.env['estate.property.type'].search([])
 
     def action_set_sold(self):
-        for record in self:
-            if record.state == 'cancelled':
-                raise UserError("Canceled properties cannot be set as sold.")
-            record.state = 'sold'
+        for property in self:
+            if property.state == 'cancelled':
+                raise UserError(_("Canceled properties cannot be set as sold."))
+            property.state = 'sold'
         return True
 
     def action_cancel(self):
-        for record in self:
-            if record.state == 'sold':
-                raise UserError("Sold properties cannot be canceled.")
-            record.state = 'cancelled'
+        for property in self:
+            if property.state == 'sold':
+                raise UserError(_("Sold properties cannot be canceled."))
+            property.state = 'cancelled'
         return True
 
     @api.ondelete(at_uninstall=False)
     def _check_unlink_state(self):
-        for record in self:
-            if record.state not in ('new', 'cancelled'):
-                raise UserError("You cannot delete a property that is not in 'New' or 'Cancelled' state.")
+        for property in self:
+            if property.state not in ('new', 'cancelled'):
+                raise UserError(_("You cannot delete a property that is not in 'New' or 'Cancelled' state."))
 
     @api.constrains('expected_price', 'selling_price')
     def _check_selling_price(self):
-        for record in self:
-            if not float_is_zero(record.expected_price, precision_digits=2):
-                accepted_offers = record.offers_ids.filtered(lambda o: o.status == 'accepted')
+        for property in self:
+            if not float_is_zero(property.expected_price, precision_digits=2):
+                accepted_offers = property.offers_ids.filtered(lambda o: o.status == 'accepted')
                 if accepted_offers:
-                    if float_compare(record.selling_price, record.expected_price * 0.90, precision_digits=2) == -1:
+                    if float_compare(property.selling_price, property.expected_price * 0.90, precision_digits=2) == -1:
                         raise ValidationError("Selling price cannot be lower than 90 percent of expected price")
 
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
-        for record in self:
-            record.total_area = record.living_area + record.garden_area
+        for property in self:
+            property.total_area = property.living_area + property.garden_area
 
     @api.depends('offers_ids.price')
     def _compute_best_price(self):
-        for record in self:
-            if record.offers_ids:
-                record.best_price = max(record.offers_ids.mapped('price'))
+        for property in self:
+            if property.offers_ids:
+                property.best_price = max(property.offers_ids.mapped('price'))
             else:
-                record.best_price = 0.0
+                property.best_price = 0.0
 
     @api.onchange('garden')
     def _onchange_garden(self):

estate/models/estate_property_offer.py

@@ -1,4 +1,4 @@
-from odoo import api, models, fields
+from odoo import _, api, models, fields
 from dateutil.relativedelta import relativedelta
 
 from odoo.exceptions import UserError
@@ -30,54 +30,56 @@ class EstatePropertyOffer(models.Model):
     ]
 
     @api.model_create_multi
-    def create(self, vals):
-        for val in vals:
+    def create(self, vals_list):
+        for val in vals_list:
             property_id = val.get('property_id')
-            price = val.get('price')
+            if not property_id:
+                continue
+            price = val.get('price', 0)
 
             prop = self.env['estate.property'].browse(property_id)
 
             existing_offer_prices = prop.offers_ids.mapped('price')
             if existing_offer_prices:
                 max_existing_offer = max(existing_offer_prices)
                 if float_compare(price, max_existing_offer, precision_digits=2) < 0:
-                    raise UserError("Cannot create an offer with a price lower than an existing offer")
+                    raise UserError(_("Cannot create an offer with a price lower than an existing offer"))
 
             if prop.state == 'new':
                 prop.write({'state': 'offer_received'})
 
-        new_offer = super().create(vals)
+        new_offer = super().create(vals_list)
         return new_offer
 
     def action_accept(self):
-        for record in self:
-            accepted_offers = record.property_id.offers_ids.filtered(lambda o: o.status == 'accepted')
+        for offer in self:
+            accepted_offers = offer.property_id.offers_ids.filtered(lambda o: o.status == 'accepted')
             if accepted_offers:
-                raise UserError("Another offer has already been accepted for this property.")
-            record.status = 'accepted'
-            record.property_id.state = 'offer_accepted'
-            record.property_id.selling_price = record.price
-            record.property_id.buyer_id = record.partner_id
+                raise UserError(_("Another offer has already been accepted for this property."))
+            offer.status = 'accepted'
+            offer.property_id.state = 'offer_accepted'
+            offer.property_id.selling_price = offer.price
+            offer.property_id.buyer_id = offer.partner_id
         return True
 
     def action_refuse(self):
-        for record in self:
-            record.status = 'refused'
+        for offer in self:
+            offer.status = 'refused'
         return True
 
     @api.depends('create_date', 'validity')
     def _compute_date_deadline(self):
-        for record in self:
-            if record.create_date:
-                base_date = record.create_date.date()
+        for offer in self:
+            if offer.create_date:
+                base_date = offer.create_date.date()
             else:
                 base_date = fields.Date.today()
-            record.date_deadline = base_date + relativedelta(days=record.validity)
+            offer.date_deadline = base_date + relativedelta(days=offer.validity)
 
     def _inverse_date_deadline(self):
-        for record in self:
-            if record.create_date:
-                base_date = record.create_date.date()
+        for offer in self:
+            if offer.create_date:
+                base_date = offer.create_date.date()
             else:
                 base_date = fields.Date.today()
-            record.validity = (record.date_deadline - base_date).days
+            offer.validity = (offer.date_deadline - base_date).days

estate/views/estate_property_views.xml

@@ -136,7 +136,7 @@
                     <field name="facades"/>
                     <filter name="available" string="Available" domain="[('state', 'in', ['new', 'offer_received'])]"/>
                     <group expand="1" string="Group By">
-                        <filter string="Postcode" name="postcode" context="{'group_by':'postcode'}"/>
+                        <filter string="Postcode" name="postcode" context="{'group_by': 'postcode'}"/>
                     </group>
                 </search>
             </field>

estate/views/res_users_views.xml

@@ -13,4 +13,4 @@
             </field>
         </record>
     </data>
-</odoo>
+</odoo>

estate_account/__manifest__.py

@@ -1,12 +1,19 @@
 {
     'name': "Real Estate Accounting Link",
+    'summary': "Link estate and account modules for creating invoice",
+    'description': """
+This module is used as a bridge between estate and account modules in order to create an invoice automatically when marking a property as sold
+    """,
+    'author': 'Odoo',
+    'version': '1.0',
     'depends': [
         'estate',
         'account',
     ],
     'data': [
     ],
     'installable': True,
+    'auto_install': True,
     'application': False,
     'license': 'LGPL-3',
 }

estate_account/models/estate_property.py

@@ -1,4 +1,4 @@
-from odoo import models, Command
+from odoo import _, models, Command
 from odoo.exceptions import UserError
 
 
@@ -11,14 +11,14 @@ def action_set_sold(self):
         if not self:
             return res
 
-        for record in self:
-            if not record.buyer_id:
-                raise UserError("Cannot create invoice: Buyer is not set for property")
+        for property in self:
+            if not property.buyer_id:
+                raise UserError(_("Cannot create invoice: Buyer is not set for property"))
 
-            if record.selling_price <= 0:
-                raise UserError("Cannot create invoice: Selling price must be positive for property")
+            if property.selling_price <= 0:
+                raise UserError(_("Cannot create invoice: Selling price must be positive for property"))
 
-            commission = record.selling_price * 0.06
+            commission = property.selling_price * 0.06
             admin_fees = 100.00
 
             invoice_line_commands = [
@@ -35,7 +35,7 @@ def action_set_sold(self):
             ]
 
             invoice_vals = {
-                'partner_id': record.buyer_id.id,
+                'partner_id': property.buyer_id.id,
                 'move_type': 'out_invoice',
                 'invoice_line_ids': invoice_line_commands,
             }