Skip to content

Commit 523a463

Browse files
authored
chore: update env variables and documentation (#250)
* ODTP_DASHBOARD_JSON_EDITOR is no longer used * ALLOW_DOCKER_GPUS is new to allow or disallow GPU flag in docker run Co-authored-by: sabinem <[email protected]>
1 parent a398ba1 commit 523a463

6 files changed

+9
-13
lines changed

.env.dist.compose

+2-5
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,5 @@ ODTP_LOG_LEVEL=ERROR
4343
# Log Level when running executions
4444
RUN_LOG_LEVEL=INFO
4545

46-
# App Path
47-
APP_PATH=
48-
49-
# Install the package in editable mode.
50-
PIP_INSTALL_ARGS="--editable"
46+
# set to False if your docker installation does not allow the flag --gpus all
47+
ALLOW_DOCKER_GPUS=False

.env.dist.compose.dev

+3
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,6 @@ APP_PATH=
4949

5050
# Install the package in editable mode.
5151
PIP_INSTALL_ARGS="--editable"
52+
53+
# set to False if your docker installation does not allow the flag --gpus all
54+
ALLOW_DOCKER_GPUS=False

.env.dist.local

+3
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,6 @@ ODTP_LOG_LEVEL=ERROR
3737

3838
# Log Level when running executions
3939
RUN_LOG_LEVEL=INFO
40+
41+
# set to False if your docker installation does not allow the flag --gpus all
42+
ALLOW_DOCKER_GPUS=False

compose.dev.yml

-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ services:
2727
ODTP_MONGO_DB: ${ODTP_MONGO_DB}
2828
ODTP_DASHBOARD_PORT: ${ODTP_DASHBOARD_PORT}
2929
ODTP_DASHBOARD_RELOAD: ${ODTP_DASHBOARD_RELOAD}
30-
ODTP_DASHBOARD_JSON_EDITOR: ${ODTP_DASHBOARD_JSON_EDITOR}
3130
ODTP_LOG_LEVEL: ${ODTP_LOG_LEVEL}
3231
RUN_LOG_LEVEL: ${RUN_LOG_LEVEL}
3332
ALLOW_DOCKER_GPUS: ${ALLOW_DOCKER_GPUS:-True}

compose.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ services:
2222
ODTP_PASSWORD: ${ODTP_PASSWORD}
2323
ODTP_MONGO_DB: ${ODTP_MONGO_DB}
2424
ODTP_DASHBOARD_PORT: ${ODTP_DASHBOARD_PORT}
25-
ODTP_DASHBOARD_JSON_EDITOR: ${ODTP_DASHBOARD_JSON_EDITOR}
2625
ODTP_LOG_LEVEL: ${ODTP_LOG_LEVEL}
2726
RUN_LOG_LEVEL: ${RUN_LOG_LEVEL}
27+
ALLOW_DOCKER_GPUS: ${ALLOW_DOCKER_GPUS:-True}
2828

2929
stdin_open: true
3030
tty: true

odtp/helpers/settings.py

-6
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ class OdtpSettingsException(Exception):
4040
else:
4141
ODTP_DASHBOARD_RELOAD = False
4242

43-
ODTP_DASHBOARD_JSON_EDITOR = os.getenv("ODTP_DASHBOARD_JSON_EDITOR")
44-
if ODTP_DASHBOARD_JSON_EDITOR in ["False", "True"]:
45-
ODTP_DASHBOARD_JSON_EDITOR = eval(ODTP_DASHBOARD_JSON_EDITOR)
46-
else:
47-
ODTP_DASHBOARD_JSON_EDITOR = False
48-
4943
ODTP_PATH = os.getenv("ODTP_PATH")
5044

5145
ODTP_LOG_LEVEL = os.getenv("ODTP_LOG_LEVEL")

0 commit comments

Comments
 (0)