compile error on Mac wrt aligned allocation

[offleash-dev]

Hi. I'm trying to integrate Quill into a Windows/Mac project. I did the initial integration on Windows and have it working. It's good.

When I pulled the work onto an M2 Mac, I get the following error:

quill/include/quill/core/UnboundedSPSCQueue.h:76:17: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t)' is only available on macOS 10.13 or newer
76 | : _producer(new Node(initial_bounded_queue_capacity, huge_pages_policy)), _consumer(_producer)
| ^

I reinstalled the latest Xcode CLI tools, I assume I'm using the latest clang. The docs indicated Mac support. There is a little chatter on other projects about a compiler flag, -faligned-allocation, but I haven't worked through that yet with Quill.

Any thoughts?
Thanks for
Matt

Update:
As above, the docs indicate Mac support, but does Quill support the platform? Maybe it is assumed because unix underpinnings? I made progress by targeting MacOS SDK 10.15 for deployment. But then I run into issues where the MacOS Clang doesn't have std::filesystem, which Quill relies on. I'm contemplating adding "https://github.com/gulrak/filesystem.git" to Quill (on Mac at least) to solve this

[odygrd]

Hey, thanks for reporting. Yes, Quill does support macOS, I actually tested master on my old x86 MacBook running macOS 11 today, and it compiled successfully there.

I suspect the alignment issue might be specific to Apple Silicon on macOS 12. If you happen to find a workaround, please let me know—I’d appreciate it

It does work on Apple Silicon as well. Unfortunately, I’m currently using an M3 with macOS 14, so I can’t easily test macOS 12. There’s also a CI job for macOS 14 running on GitHub runners with Apple Silicon, and it’s been working fine on macOS 13 before too.

You can check out the workflow here:

• macOS CI Workflow
• GitHub Hosted Runners Description

As for the std::filesystem issue, I believe macOS SDK 10.15 didn’t have full support for it, which could explain the problems you're encountering. macOS 12 has also reached the end of life and no longer receives security updates, apple usually only supports the latest versions.

Let me know how things go, and if I can help with anything else

ody@MacBook-Pro ~ % xcodebuild -version
Xcode 13.2.1
Build version 13C100

ody@MacBook-Pro ~ % sw_vers
ProductName:	macOS
ProductVersion:	11.7.6
BuildVersion:	20G1231

ody@MacBook-Pro ~ % xcode-select --version
xcode-select version 2384.

ody@MacBook-Pro ~ % clang --version
Apple clang version 13.0.0 (clang-1300.0.29.30)
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

[odygrd]

I tried to cross compile from macOS 11 x86 but it did not help to reproduce the issue

SET(CMAKE_SYSTEM_NAME Darwin)
SET(CMAKE_SYSTEM_PROCESSOR arm64)
SET(CMAKE_OSX_ARCHITECTURES "arm64") 

-- The C compiler identification is AppleClang 13.0.0.13000029
-- The CXX compiler identification is AppleClang 13.0.0.13000029

Run Build Command(s): /Applications/CLion.app/Contents/bin/ninja/mac/x64/ninja -v -j 6 quill_example_console_logging

[1/2] /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -I/Users/ody/CLionProjects/quill/include -g -std=gnu++17 -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk -mmacosx-version-min=11.7 -fcolor-diagnostics -Wall -Wextra -pedantic -Werror -Wredundant-decls -Wfloat-equal -Wimplicit-int-float-conversion -Wdocumentation -Wno-gnu-zero-variadic-macro-arguments -MD -MT examples/CMakeFiles/quill_example_console_logging.dir/console_logging.cpp.o -MF examples/CMakeFiles/quill_example_console_logging.dir/console_logging.cpp.o.d -o examples/CMakeFiles/quill_example_console_logging.dir/console_logging.cpp.o -c /Users/ody/CLionProjects/quill/examples/console_logging.cpp

[2/2] : && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -g -arch arm64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk -mmacosx-version-min=11.7 -Wl,-search_paths_first -Wl,-headerpad_max_install_names  examples/CMakeFiles/quill_example_console_logging.dir/console_logging.cpp.o -o examples/quill_example_console_logging   && :


Build finished

ody@MacBook examples % file quill_example_console_logging
quill_example_console_logging: Mach-O 64-bit executable arm64

[offleash-dev]

Hey
The project had a historical SDK target of 10.10.
If I change the target to:
CMAKE_OSX_DEPLOYMENT_TARGET "10.15"
then it builds with Quill references.

If I change that minimum target to 10.14, clang balks again, but this time the alignment errors go away and use of the standard filesystem calls causes the error, e.g.

error: 'path' is unavailable: introduced in macOS 10.15
38 | std::function<void(fs::path const& file_path)> before_open;

I'll confirm it's ok to force a big jump in the OS minimum, but maybe will end up using that standard file system project I mentioned above (/gulrak/filesystem.git) for at least a few older OS versions.

FWIW, I am using a later clang than the one in your output.
"-- The C compiler identification is AppleClang 16.0.0.16000026"

Thanks for your help
Matt