Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gen): goimports takes up to 60% time of generation #484

Open
tdakkota opened this issue Jul 15, 2022 · 0 comments
Open

perf(gen): goimports takes up to 60% time of generation #484

tdakkota opened this issue Jul 15, 2022 · 0 comments
Labels
area: gen Generator issues performance Performance issues

Comments

@tdakkota
Copy link
Member

The CPU profile gathered from corpus collector latest run.

(pprof) top -cum x/tools
Active filters:
   focus=x/tools
Showing nodes accounting for 0.19s, 0.0093% of 2037.73s total
Dropped 977 nodes (cum <= 10.19s)
Showing top 10 nodes out of 226
      flat  flat%   sum%        cum   cum%
     0.04s 0.002% 0.002%    1162.91s 57.07%  golang.org/x/tools/internal/imports.Process
     0.04s 0.002% 0.0039%   1160.32s 56.94%  golang.org/x/tools/imports.Process
         0     0% 0.0039%   1157.15s 56.79%  github.com/ogen-go/ogen/gen.(*writer).Generate
         0     0% 0.0039%   1152.79s 56.57%  github.com/ogen-go/ogen/gen.(*Generator).WriteSource
         0     0% 0.0039%   1148.14s 56.34%  main.generate
         0     0% 0.0039%   1142.38s 56.06%  main.worker
         0     0% 0.0039%   1136.30s 55.76%  main.run.func7
         0     0% 0.0039%   1129.19s 55.41%  golang.org/x/sync/errgroup.(*Group).Go.func1

Also see: #66.

@tdakkota tdakkota added performance Performance issues area: gen Generator issues labels Jul 15, 2022
@tdakkota tdakkota changed the title perf: goimports takes up to 60% time of generation perf(gen): goimports takes up to 60% time of generation Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: gen Generator issues performance Performance issues
Projects
None yet
Development

No branches or pull requests

1 participant