Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue Spring Boot CRUD updated #1244

Merged
merged 85 commits into from
Aug 19, 2022
Merged

Vue Spring Boot CRUD updated #1244

merged 85 commits into from
Aug 19, 2022

Conversation

moksamedia
Copy link
Contributor

@moksamedia moksamedia commented Aug 16, 2022 •
edited by mraible
Loading

This blog post has the following features:

  • A GitHub Repository with a polished README
  • A GitHub Repository under the github.com/oktadev account
  • A title that's approved by Dev Advocacy
  • A URL that's approved by Dev Advocacy
  • The content has been run through Grammarly (https://www.grammarly.com/)
  • Rendered locally and confirmed that no Markdown typos exist

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for okta-blog ready!

Name Link
🔨 Latest commit 678ca75
🔍 Latest deploy log https://app.netlify.com/sites/okta-blog/deploys/62ffa0c3ac10720007f63818
😎 Deploy Preview https://deploy-preview-1244--okta-blog.netlify.app/blog/2022/08/19/build-crud-spring-and-vue
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@moksamedia moksamedia changed the title ready for pr Vue Spring Boot CRUD updated Aug 16, 2022
@mraible mraible mentioned this pull request Aug 16, 2022
Merged
mraible
mraible reviewed Aug 16, 2022
View reviewed changes
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated
<q-card class="my-card">
<q-card-section style="text-align: center">
<div v-if='authState && authState.isAuthenticated' >
<h6 v-if="claims && claims.email">You are logged in as {{ '{{' }}claims.email}}</h6>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to wrap the whole code block with {% raw %} and {% endraw %}.

mraible
mraible suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@mraible mraible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick pass and looked for low-hanging fruit. The screenshots look excellent, so I look forward to QAing tomorrow!

@havi You can probably start on copy editing if you like.

_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
_source/_posts/2022-08-15-spring-boot-crud-update.md Outdated Show resolved Hide resolved
@havi havi self-requested a review August 17, 2022 15:58
@mraible mraible enabled auto-merge (squash) August 19, 2022 04:36
@havi havi self-requested a review August 19, 2022 14:13
havi
havi reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@havi havi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of small tweaks - mostly punctuation and capitalization. thanks. After that, let's ship it.

@havi havi self-requested a review August 19, 2022 14:41
@mraible mraible merged commit 7603730 into oktadev:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havi havi havi approved these changes

@mraible mraible mraible approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moksamedia @mraible @havi