From d5975f506efaf09b71db161385a8830f9c0f8a70 Mon Sep 17 00:00:00 2001
From: Oleg Andreyev <oleg@andreyev.lv>
Date: Sat, 28 Dec 2024 17:23:50 +0200
Subject: [PATCH] added headless to matrix (#94)

* added headless to matrix

* changed job name

* fix: Archive logs artifacts name

* trigger
---
 .github/workflows/ci.yml | 25 ++++++++++++++++++++++---
 README.md                |  2 +-
 2 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 995d8f5..e3f58f9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -20,6 +20,7 @@ defaults:
 
 jobs:
   static:
+    name: Static analysis
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -55,12 +56,14 @@ jobs:
         php: [ 8.1, 8.2, 8.3 ]
         browser: [ chrome, firefox ]
         experimental: [false]
+        headless: [true, false]
         include:
           - php: 8.4
             experimental: true
             browser: chrome
     continue-on-error: ${{ matrix.experimental }}
     timeout-minutes: 5
+    name: PHP=${{ matrix.php }}; Browser=${{ matrix.browser }}; Headless=${{ matrix.headless }}; Experimental=${{ matrix.experimental }}
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -112,16 +115,24 @@ jobs:
       - name: Start ChromeDriver
         if: ${{ matrix.browser == 'chrome' }}
         run: |
-          xvfb-run --server-args="-screen 0, 1280x720x24" --auto-servernum \
+          if [ ${{ matrix.headless }} == "true" ]; then
             chromedriver --port=4444 --verbose --whitelisted-ips= &> ./logs/chromedriver.log &
+          else
+            xvfb-run --server-args="-screen 0, 1280x720x24" --auto-servernum \
+              chromedriver --port=4444 --verbose --whitelisted-ips= &> ./logs/chromedriver.log &
+          fi
           
           while ! nc -z localhost 4444 </dev/null; do echo Waiting for driver to start...; sleep 1; done
 
       - name: Start GeckoDriver
         if: ${{ matrix.browser == 'firefox' }}
         run: |
-          xvfb-run --server-args="-screen 0, 1280x720x24" --auto-servernum \
+          if [ ${{ matrix.headless }} == "true" ]; then
             geckodriver --host 127.0.0.1 -vv --port 4444 &> ./logs/geckodriver.log &
+          else
+            xvfb-run --server-args="-screen 0, 1280x720x24" --auto-servernum \
+              geckodriver --host 127.0.0.1 -vv --port 4444 &> ./logs/geckodriver.log &
+          fi
           
           while ! nc -z localhost 4444 </dev/null; do echo Waiting for driver to start...; sleep 1; done
 
@@ -136,12 +147,20 @@ jobs:
           SYMFONY_DEPRECATIONS_HELPER: 'max[total]=999999'
           BROWSER_NAME: ${{ matrix.browser }}
         run: |
+          if [ ${{ matrix.headless }} == "true" ]; then
+            if [ ${{ matrix.browser }} == "chrome" ]; then
+              export DRIVER_OPTIONS='{"args":["headless=new"]}'
+            elif [ ${{ matrix.browser }} == "firefox" ]; then
+              export DRIVER_OPTIONS='{"args": ["-headless"]}'
+            fi
+          fi
+          
           ./bin/phpunit -v
 
       - name: Archive logs artifacts
         if: ${{ always() }}
         uses: actions/upload-artifact@v4
         with:
-          name: logs_browser-${{ matrix.browser }}_php-${{ matrix.php }}
+          name: logs_browser-${{ matrix.browser }}_php-${{ matrix.php }}_headless-${{ matrix.headless }}_experimental-${{ matrix.experimental }}
           path: |
             logs
diff --git a/README.md b/README.md
index f1894e0..189871c 100644
--- a/README.md
+++ b/README.md
@@ -42,4 +42,4 @@ Follow https://github.com/shivammathur/setup-php#local-testing-setup
 
 ## Copyright
 
-Copyright (c) 2024 Oleg Andreyev <oleg@andreyev.lv>
+Copyright (c) 2024 Oleg Andreyev <oleg@andreyev.lv>
\ No newline at end of file