[rls-v3.7] benchdnn: graph, graph: backend: enable implicit causal mask in sdpa primitive #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
|
make test |
wzt1997
approved these changes
Jan 17, 2025
|
I propose to marinate this PR until we get at least one validation Nightly cycle on main to make sure that everything passes everywhere to avoid extra backport work. |
Sure, make sense, let's wait and see the nightly report. |
TaoLv
approved these changes
Jan 17, 2025
ElaineBao
force-pushed
the
yixin/backport_enable_sdpa_primitive
branch
from
a81476c to
2a72913
Compare
|
make test |
The driver lacks the proper support of this functionality.
sdpa patterns including float sdpa and sdpa with compressed k/v
cases of sdpa compressed kv with implicit causal mask
filter out implicit causal mask in sdp decomp kernel
dzarukin
approved these changes
Jan 22, 2025
ElaineBao
force-pushed
the
yixin/backport_enable_sdpa_primitive
branch
from
2a72913 to
3b0b3cc
Compare
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #2410, #2369 and #2457 to v3.7.