Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API origins #13

Open
bunsenstraat opened this issue Feb 24, 2021 · 1 comment
Open

API origins #13

bunsenstraat opened this issue Feb 24, 2021 · 1 comment

Comments

@bunsenstraat
Copy link

concerning the update for vscode, we noticed that your api blocks the origin of the plugin. That is because the origin is something like this:
vscode-webview://b421f05c-bc2d-4615-afaa-2a4df3cbdfb1

This is the webview component of vscode where the plugins renders. It would be awesome if that could be allowed.
Glad to discuss the ideas. Currently vscode doesn't support custom origins. It's just this.

@pi0neerpat
Copy link
Collaborator

Thank you for the heads up! I never would have discovered that.

I've update CORS to wildcard, so this should be fixed.

Eventually I will figure out how to use Regex here so as to not use wildcard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants