Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification Needed on Logger/LoggerFactory Usage #1084

Open
netanelb-carbyne opened this issue Jun 18, 2024 · 0 comments
Open

Clarification Needed on Logger/LoggerFactory Usage #1084

netanelb-carbyne opened this issue Jun 18, 2024 · 0 comments

Comments

@netanelb-carbyne
Copy link

Dear Team,

I hope this message finds you well.

I would like to bring to your attention a critical issue regarding our current usage of the eslint rule no-console. This rule exists for a reason, and it's crucial that we address its implications properly.

Here is an example scenario to illustrate the problem:

  1. An error occurs in the code.
  2. The logger is activated.
  3. As a program, we are unable to determine what exactly happened.

To resolve this, it is essential to clearly define the purpose of our logger:

  • External Logging: If the logger is intended for external logging, we should emit the logs to the outside world, allowing them to decide how to handle it.
  • Internal Use: If the logger is for internal use, we should utilize the debugger instead.

By addressing this issue, we can ensure that our logging practices are both effective and compliant with best practices.

Thank you for your attention to this matter. I look forward to your feedback and suggestions.

Best regards,
Netanel Baba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant