Skip to content

feat!: update the observability appendix to include the latest otel semcon #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

feat!: update the observability appendix to include the latest otel semcon #306

merged 5 commits into from
May 13, 2025

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Apr 14, 2025 •
edited
Loading

This PR

  • update the observability appendix to include the latest otel semcon

Notes

Marking as a draft until we find out if value can be moved out from the body.

https://docs.google.com/document/d/1x9hprUaUNlVCZMtFAqBcj6h50ukpT0hCAli7BzgWsTQ/edit?tab=t.0

@beeme1mr
Copy link
Member Author

Depends on changes in the Weaver tool in OTel.

open-telemetry/weaver#703

Once Weaver has been updated to support an any type, we can move value out of the body.

@beeme1mr beeme1mr marked this pull request as ready for review April 23, 2025 18:04
@beeme1mr beeme1mr requested a review from toddbaert as a code owner April 23, 2025 18:04
@beeme1mr beeme1mr marked this pull request as draft April 23, 2025 18:05
@beeme1mr
Copy link
Member Author

I've updated the spec to include all the changes recommended by the OTel team. It's ready to be reviewed but we shouldn't merge it until the OTel tooling has been merged.

FYI @kinyoklion

dyladan
dyladan reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. I think it would be better if there was more guidance about when to use variant vs value.

@beeme1mr beeme1mr marked this pull request as ready for review May 12, 2025 18:24
dyladan
dyladan approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Footnotes are a lot better IMO

@beeme1mr beeme1mr merged commit c66684f into main May 13, 2025
7 checks passed
@beeme1mr beeme1mr deleted the update-observablity-spec branch May 13, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@askpt askpt askpt approved these changes

@kinyoklion kinyoklion kinyoklion approved these changes

@aepfli aepfli aepfli approved these changes

@chrfwow chrfwow chrfwow approved these changes

@thomaspoignant thomaspoignant thomaspoignant approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

@alexandraoberaigner alexandraoberaigner Awaiting requested review from alexandraoberaigner

@jonathannorris jonathannorris Awaiting requested review from jonathannorris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@beeme1mr @dyladan @askpt @kinyoklion @aepfli @chrfwow @thomaspoignant @lukas-reining