Return 'service fetch config' api data with original text case #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5096 +/- ##
=======================================
Coverage 96.73% 96.73%
=======================================
Files 774 775 +1
Lines 26657 26662 +5
Branches 3468 3468
=======================================
+ Hits 25787 25792 +5
Misses 608 608
Partials 262 262 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Feb 11, 2025
| @@ -466,6 +466,151 @@ def assertState(): | |||
|
|
|||
| await assertState() | |||
|
|
|||
| @skip_on_webtest | |||
There was a problem hiding this comment.
Is this needed?I have no experience with this decorator tbh.
There was a problem hiding this comment.
Yeah the enter_json_in_editor helper function apparently doesn't work correctly for webkit browsers in playwright. I haven't tested it personally, but after reading the comments in enter_json_in_editor, it seems best to just skip webkit for this test
sergei-maertens
requested changes
Feb 12, 2025
robinmolen
force-pushed
the
fix/5089-service-fetch-changing-case-type
branch
from
1f54066 to
049583f
Compare
When using an existing service fetch config, that uses snake_case for the `query_params` or `body`, the `query_params` and `body` are turned to camelCase
Make sure that `body` and `query_params` on service fetch configuration keep their original case type
robinmolen
force-pushed
the
fix/5089-service-fetch-changing-case-type
branch
from
049583f to
de6393a
Compare
sergei-maertens
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5089
Changes
Make sure that the GET request to the
api/v2/service-fetch-configurationscall returnsquery_paramsandbodydata using the correct text case typeChecklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene