Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft requirement of uploads block next step #5090

Open
LaurensBurger opened this issue Feb 7, 2025 · 5 comments · May be fixed by #5116
Open

Soft requirement of uploads block next step #5090

LaurensBurger opened this issue Feb 7, 2025 · 5 comments · May be fixed by #5116
Assignees
Labels
needs-backport Fix must be backported to stable release branch owner: den-haag

Comments

@LaurensBurger
Copy link
Collaborator

Product versie / Product version

3.0.2

Customer reference

DH

Omschrijf het probleem / Describe the bug

When a step has soft requirements navigating to the next step is blocked, regardless of whether a file has been uploaded or not:

Without
Image

With
Image

the "Next" button gets disabled after clicking.

form 737 on test

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

Screen resolution

None

Device

None

OS

None

Browser

No response

@LaurensBurger LaurensBurger added the triage Issue needs to be validated. Remove this label if the issue considered valid. label Feb 7, 2025
@joeribekker
Copy link
Contributor

Refinement: State event sync issue?
Estimate: 3-4 days

@joeribekker joeribekker added owner: den-haag needs-backport Fix must be backported to stable release branch and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Feb 10, 2025
@vaszig vaszig moved this from Todo to In Progress in Development Feb 11, 2025
@vaszig vaszig moved this from In Progress to Todo in Development Feb 13, 2025
@vaszig
Copy link
Contributor

vaszig commented Feb 19, 2025

Tried to reproduce this locally on latest by doing the following:

  • export the problematic form from the test env and import it locally (this had the problem locally as well)
  • create a new form with the same components and their configuration (no problem-expected behavior)

So, after doing a diff for each component's configuration in the problematic form, I realized that the one for the soft required errors had a custom JSON field value ("validate": {"required": true) and not the default one. This is not allowing the user to proceed to the next step.

@LaurensBurger @sergei-maertens I guess this is not a real bug but a wrong configuration. Do you agree?

@vaszig vaszig moved this from Todo to Implemented in Development Feb 19, 2025
@sergei-maertens
Copy link
Member

I suspect it's an issue with the global configuration to mark components required by default (which is off by default but on for DH)

@vaszig
Copy link
Contributor

vaszig commented Feb 21, 2025

I suspect it's an issue with the global configuration to mark components required by default (which is off by default but on for DH)

Thanks, I will take a look.

@sergei-maertens
Copy link
Member

Workaround is to edit the JSON of the component and remove that validate bit. We'll backport the fix for the root cause, but automated fixes with migrations in backports are annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch owner: den-haag
Projects
Status: Implemented
Development

Successfully merging a pull request may close this issue.

4 participants