Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 555 increase version of cpu and gps #580

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

t-fine
Copy link
Collaborator

@t-fine t-fine commented Feb 28, 2023

Before closing issue #555 I wanted to inclement the version, build and push both CPU_PERCENT and GPS

@t-fine t-fine requested a review from johnwalicki February 28, 2023 00:58
Copy link
Member

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnwalicki
Copy link
Member

Great - we should encourage @bencourliss to sweep these new example versions into the next release.

Is there any step to get these new versions available on DockerHub?

https://github.com/open-horizon/examples/blob/master/tools/blessedSamples.txt

https://github.com/open-horizon/anax/blob/master/agent-install/edgeNodeFiles.sh

@t-fine t-fine linked an issue Feb 28, 2023 that may be closed by this pull request
@t-fine t-fine merged commit 954d86b into open-horizon:master Feb 28, 2023
@t-fine
Copy link
Collaborator Author

t-fine commented Feb 28, 2023

Awesome, thanks for the review @johnwalicki ! Just having the new version numbers in hzn.json will now cause these new versions to be bundled into the next release when Ben runs those pipelines. And I've built and pushed them to the openhorizon docker hub 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU_PERCENT and GPS examples do not expose port
2 participants