Where is the Makefile change?

Whoops, forgot to commit that file! It's added now.

@mpeiffer The build pipeline is failing with:

 Step 12/16 : COPY --from=0 /build/bin/${ARCH}_gps /gps
invalid from flag value 0: image with reference sha256:c1346d0f7e401c44cec06a72b15a1a04213467bf7eede44e4c287c041b8a4e67 was found but does not match the specified platform: wanted linux/arm, actual: linux/amd64
make[1]: Leaving directory '/home/runner/work/examples/examples/edge/services/gps'
make[1]: *** [Makefile:19: build] Error 1
make: *** [Makefile:30: test-all-arches] Error 2

The intermediate build stage is called go_build not 0
The attribution comments in line 1 and 2 are unnecessary and can be deleted. We can see that from the git blame.

I always run the make build whatever on my system before creating a PR. That would quickly shake out these typo bugs. Sometimes its complex to reproduce the build environment, but in this case, its straightforward (says the Linux developer for 20+ yrs... ;-) )

While you are preparing another commit, can you also rebase to the golang:1.19-alpine image ? Thx

Ah, sorry about that! Unfortunately I won't have my laptop until this Friday, as I will be out of town but I will fix it as soon as I get back. Do you want me to close the PR until then and reopen it after I make the fix?

Ah, sorry about that! Unfortunately I won't have my laptop until this Friday, as I will be out of town but I will fix it as soon as I get back. Do you want me to close the PR until then and reopen it after I make the fix?

No worries. We'll keep it open and warm until you get back and ready to tackle it again.

Hmm The pipeline test build failed. I need to run it on my system to understand better.

https://github.com/open-horizon/examples/actions/runs/3353298023/jobs/5556541067

Will hold off on the merge until Monday.

Using the Dockerfile and Makefile from this PR, I successfully built all three arch {amd64, arm, arm64} containers on my Fedora system. I manually tested the containers on devices running those three architectures. They ran successfully.

I don't why the test pipeline has a problem (Its running Image: ubuntu-20.04 )

@mpeiffer
For giggles, I added a LABEL to the Dockerfile immediate stage (which is a good idea so that we clean up immediate stages)

FROM golang:1.19-alpine as go_build
LABEL stage=builder

and modified the Makefile to prune the intermediate stage after each build step.

build:
	docker build --build-arg ARCH=$(ARCH) --platform linux/$(ARCH) -t $(DOCKER_IMAGE_BASE)_$(ARCH):$(SERVICE_VERSION) -f ./Dockerfile .
	@docker image prune --filter label=stage=builder --force

You might want to add the above and see if that helps the test-all-arches succeed.

@jonwalicki Thank you for manually testing on your end! I was also able to build and run all three arch containers on windows. I'll try adding those changes and see if it fixes anything.

I think the error is in the GHA Build / test pipeline, not the code here.
Let's chat with @t-fine

That sounds good to me. Would it be possible to add the hacktoberfest-accepted label to this while we try to resolve the issue? If it turns out there's something on my end that needs to get done I can continue working on it past October.

@mpeiffer @johnwalicki I'll add hacktoberfest-accepted label to this since you were able to build and run the services on all arches ... I'll see if I can't figure out what's going on with the GitHub action

@t-fine Thanks for looking into it! A label was added but for it to be counted it should be hacktoberfest-accepted, not hacktoberfest-approved.

@t-fine Thanks for the investigation and fix. Let's merge.

Will do! Pushed the changes. Merging once the Github action passes again.

@johnwalicki @t-fine Thank you for looking over this and for pushing the fix!